Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22602
Thank you, @mgaido91 and all.
According to the all review comments, I'll merge this to `master` and
`branch-2.4`.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96893/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96893/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96892/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96892/testReport)**
for PR 22602 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96893/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22602
two minor comments. LGTM and good catch!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96892/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96859/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96859/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96857/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96857 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96857/testReport)**
for PR 22602 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22602
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22602
LGTM, pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96859/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96857 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96857/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96852/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96852/testReport)**
for PR 22602 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96852/testReport)**
for PR 22602 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22602
thank you all for the reviews! I added the UT according to @cloud-fan's
suggestion as I was unable to set up a reasonable the end-to-end UT. Thanks.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22602
I think we can create a `UnsafeWriterSuite` to do some low-level checking.
We can leave the end-to-end test if it's too hard to write.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22602
good catch! LGTM, waiting for the UT.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22602
Thank you. The first option looks good. Let me think about a good UT, too.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96822/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22602
**[Test build #96822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96822/testReport)**
for PR 22602 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22602
@mgaido91 Could you change the title to [WIP] before you add the test case?
Also cc @hvanhovell @kiszk who are the best person to review these code.
---
42 matches
Mail list logo
