[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-02 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22604 OK, this PR should be closed then. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-02 Thread ankuriitg
Github user ankuriitg commented on the issue: https://github.com/apache/spark/pull/22604 I have opened another PR for this, with the recommended changes: https://github.com/apache/spark/pull/22616 I had to change a few other logDebug statements as well. Please let me know if

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread ankuriitg
Github user ankuriitg commented on the issue: https://github.com/apache/spark/pull/22604 Makes sense and let me update the description about SPARK-25118 --- - To unsubscribe, e-mail:

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22604 OK, backing up here, yes it's important to specify what the problem was that started this. It's exhibited in the error logs from your PR for SPARK-25118 (which is not submitted; might be worth

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread ankuriitg
Github user ankuriitg commented on the issue: https://github.com/apache/spark/pull/22604 If I remove the following code, then the test succeeds and no spark jobs are started. Shall I do this instead? ` sb.append("\n") val nd = s"Null deviance:

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22604 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96830/ Test PASSed. ---

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22604 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22604 **[Test build #96830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96830/testReport)** for PR 22604 at commit

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread ankuriitg
Github user ankuriitg commented on the issue: https://github.com/apache/spark/pull/22604 Few variables (I think there are 3) printed in toString cause a Spark Job to be started and the main reason is that those variables are lazily evaluated. I can remove those variables from

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22604 This just removes `toString` entirely and adds a new method. I don't think we can do that. What's the minimum change to `toString` that means it doesn't execute a Spark job? can the same info be

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread ankuriitg
Github user ankuriitg commented on the issue: https://github.com/apache/spark/pull/22604 @actuaryzhang @yanboliang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22604 **[Test build #96830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96830/testReport)** for PR 22604 at commit

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22604 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22604 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread ankuriitg
Github user ankuriitg commented on the issue: https://github.com/apache/spark/pull/22604 @vanzin @squito @bersprockets --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22604 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22604: [SPARK-25586][MLlib][Core] Replace toString method with ...

2018-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22604 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional