[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-11 Thread sadhen
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22685 OK. Nevermind. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@sp

[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22685 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22685 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97194/ Test PASSed. ---

[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22685 **[Test build #97194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97194/testReport)** for PR 22685 at commit [`52ed24e`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread sadhen
Github user sadhen commented on the issue: https://github.com/apache/spark/pull/22685 @HyukjinKwon Sorry. Happened to find that some code is not elegant according to my taste. I have not got the fact that massive changes are not good for backporting. As a result, I spent some time tr

[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22685 I think you're mostly trying to target changes styles. If there is not actual benefit rather then just styles, I wouldn't do this and just help review other PRs. --- -

[GitHub] spark issue #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22685 **[Test build #97194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97194/testReport)** for PR 22685 at commit [`52ed24e`](https://github.com/apache/spark/commit/52