[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-12-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23170 Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-30 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/23170 Looks good to me. Thanks for fixing this @wangyum. I guess, i tried to trim off the example to show the mutual exclusivity of these two parameters in question. --- --

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-29 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/23170 It's not a regression. The first check exists in [2.1.0](https://github.com/apache/spark/blob/v2.1.0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala#L99-L102

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/23170 @wangyum Could you check whether the example works before? Is it a regression? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23170 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23170 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99390/ Test PASSed. ---

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23170 **[Test build #99390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99390/testReport)** for PR 23170 at commit [`e2d8229`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23170 **[Test build #99390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99390/testReport)** for PR 23170 at commit [`e2d8229`](https://github.com/apache/spark/commit/e2

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23170 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5465/

[GitHub] spark issue #23170: [SPARK-24423][FOLLOW-UP][SQL] Fix error example

2018-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23170 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma