Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/9571
Could you close this PR please? @steveloughran
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
I'm going to close this PR and start one based on a reapplication of this
patch onto master; gets rid of all the merge pain and is intended to be more
minimal. The latest comments of this one
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/9571
> if you'd merged this in earlier: no merge conflicts
Well, if you're going to follow that route, if you had addressed feedback
earlier, the patch would have been merged long ago...
---
If
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
> I was secretly hoping you'd just give up on this patch, since it will
generate a lot of conflicts with the code I'm working on in parallel..
No. Sorry
I do suspect the
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
Line lengths fixed, tests all happy.
@vanzin âany chance of adding this to your review list?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75708/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #75708 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75708/testReport)**
for PR 9571 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #75708 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75708/testReport)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75704/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #75704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75704/testReport)**
for PR 9571 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #75704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75704/testReport)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
Style police. FWIW I think the lines that failed were already >100 chars,
it was just they got indented slightly more.
```
Scalastyle checks failed at following occurrences:
[error]
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73695/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #73695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73695/testReport)**
for PR 9571 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #73695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73695/testReport)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64651/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64651 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64651/consoleFull)**
for PR 9571 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64651 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64651/consoleFull)**
for PR 9571 at commit
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
sorry, didn't see that one. Will fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64586/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64586/consoleFull)**
for PR 9571 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/9571
@steveloughran you still have not addressed my comment about
`appUiLoadTimer`. The metric is still being registered even though it doesn't
make any sense to the user.
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64586/consoleFull)**
for PR 9571 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/9571
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
Test failures timeout related; unlikely to be due to this patch
```
Test Result (2 failures / +2)
org.apache.spark.sql.hive.HiveSparkSubmitSuite.dir
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64531/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64531 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64531/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64531/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64359/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64359/consoleFull)**
for PR 9571 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/9571
Looks ok but there's one comment you haven't addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #64359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64359/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63864/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #63864 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63864/consoleFull)**
for PR 9571 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #63864 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63864/consoleFull)**
for PR 9571 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/9571
A few minor things left.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62321/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62321 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62321/consoleFull)**
for PR 9571 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62321 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62321/consoleFull)**
for PR 9571 at commit
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
This patch adds separate average values of the load times vs merge times
per event; this shows ~2x difference in replay from load in the test case.,
These `.time` gauges are little
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62320 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62320/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62320/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62320 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62320/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62319/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62319/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62319/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62318/consoleFull)**
for PR 9571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62318/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #62318 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62318/consoleFull)**
for PR 9571 at commit
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
One other metric set I'm thinking of relates to a JIRA on app UIs not being
visible: making the time of last scan a metric, both as an epoch time and diff
from current time. That would let a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60296/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #60296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60296/consoleFull)**
for PR 9571 at commit
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/9571
Updated patch. Addresses indentation, found and eliminated one more call to
{{initialize()}} outside of constructor.
Adds a whole new counter, `event.replay.count`, which counts the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9571
**[Test build #60296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60296/consoleFull)**
for PR 9571 at commit
67 matches
Mail list logo
