[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10013 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-30 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160571298 Merged to master/1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160314220 **[Test build #2129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2129/consoleFull)** for PR 10013 at commit [`338c970`](https://

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160297882 **[Test build #2129 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2129/consoleFull)** for PR 10013 at commit [`338c970`](https://g

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160133967 I see your point, let's go with the same wording then, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-27 Thread mineo
Github user mineo commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160133244 I've used the same wording that the docs of `takeOrdered` use. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160128842 I think that's fine, though might say it a little differently. It returns the top k elements according to some ordering, and the k elements are in order ascending/descen

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10013#issuecomment-160087237 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [Doc] Explicitly state that top maintains the ...

2015-11-27 Thread mineo
GitHub user mineo opened a pull request: https://github.com/apache/spark/pull/10013 [Doc] Explicitly state that top maintains the order of elements Top is implemented in terms of takeOrdered, which already maintains the order, so top should, too. You can merge this pull request