Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-210369151
If there's a built-in scalastyle rule for this, let's enable it, but
otherwise not sure it's worth building custom code to enforce it. If you've
found ways to look for m
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-210359106
@andrewor14 @srowen Do you mind If I open another PR for some more
corrections?
While trying to test regular expressions, I found some more things to
corre
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-210358749
@andrewor14 Hm.. I tried to add a rule but I realised (or I think) it
cannot find perfectly by a static way. One of the problems I met was below:
For exampl
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-210088656
Maybe we should add a scalastyle rule for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209832757
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209826881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209826878
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209826329
**[Test build #55802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55802/consoleFull)**
for PR 12382 at commit
[`a62b333`](https://g
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12382#discussion_r59675641
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/RecoverableNetworkWordCount.scala
---
@@ -116,7 +116,7 @@ object RecoverableNetworkWord
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209780802
**[Test build #55802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55802/consoleFull)**
for PR 12382 at commit
[`a62b333`](https://gi
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209779860
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209778704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209778706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209778597
**[Test build #55793 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55793/consoleFull)**
for PR 12382 at commit
[`a62b333`](https://g
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209761427
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209758589
**[Test build #55793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55793/consoleFull)**
for PR 12382 at commit
[`a62b333`](https://gi
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12382#issuecomment-209758085
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/12382
[MINOR][SQL] Remove extra anonymous closure within functional
transformations
## What changes were proposed in this pull request?
This PR removes extra anonymous closure within functio
19 matches
Mail list logo
