Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-149735830
thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8271
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-149735227
Merged into master. I will send a follow-up PR to address minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8271#discussion_r38180485
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -284,6 +284,8 @@ class DenseMatrix(
override def apply(i: Int, j:
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-135638595
I think this requires some micro-benchmark. I want to see the overhead of
additional two checks. We can also test a single `require` statement that
contains both checks.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132319820
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132319780
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132319378
Actually this check is not necessary for SparseMatrices. But worst case it
saves the effort of doing a binary search (and it should not return 0.0 if the
row and col
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132319844
And I discovered the OOB bug by accident :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132320541
[Test build #41155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41155/consoleFull)
for PR 8271 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132332983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132332979
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132353692
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132353694
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132353469
[Test build #41159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41159/console)
for PR 8271 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132339896
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8271#discussion_r37347311
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -281,9 +281,13 @@ class DenseMatrix(
/**
* @since
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132336480
minor suggestion but LGTM
CC @mengxr @jkbradley for final pass
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132339964
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132332812
[Test build #41155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41155/console)
for PR 8271 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8271#issuecomment-132341361
[Test build #41159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41159/consoleFull)
for PR 8271 at commit
21 matches
Mail list logo
