[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-11-02 Thread hvanhovell
Github user hvanhovell closed the pull request at: https://github.com/apache/spark/pull/8298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-25 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-134620114 @adrian-wang the improvement is absolutely tiny, about 2-3% if you do a lot of ```min```'s of ```max```'es. This PR was a response to misdiagnosed performance

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-23 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-134054452 I doubt that whether your decision tree is better. But GreaterThan/LessThan should be a little better than Least/Greatest, I think. --- If your project is set up fo

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-23 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/8298#discussion_r37721828 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala --- @@ -236,15 +234,13 @@ case class Min(child:

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132792939 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132792936 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132792779 [Test build #41273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41273/console) for PR 8298 at commit [`3423912`](https://github.

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132752492 [Test build #41273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41273/consoleFull) for PR 8298 at commit [`3423912`](https://gith

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132751887 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132751863 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132453945 [Test build #41203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41203/console) for PR 8298 at commit [`2fed4dc`](https://github.

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132454008 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132454009 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132437956 [Test build #41203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41203/consoleFull) for PR 8298 at commit [`2fed4dc`](https://gith

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132437659 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132437669 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132437613 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8298#issuecomment-132426939 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10100] [SQL] Perfomance improvements to...

2015-08-18 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/8298 [SPARK-10100] [SQL] Perfomance improvements to new MIN/MAX aggregate functions. The new MIN/MAX suffer from a performance regression. This PR aims to fix this by simplifying the evaluation of th