Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/8373#discussion_r37787668
--- Diff: python/pyspark/streaming/tests.py ---
@@ -1240,8 +1245,8 @@ def search_kinesis_asl_assembly_jar():
mqtt_test_jar
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-134329040
Alright. I am going to merge this to master and branch 1.5. Thanks @srowen,
@vanzin and @jerryshao for taking a look.
---
If your project is set up for it, you can reply t
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-134296970
LGTM. Yeah, I've been bitten by this before - the maven install plugin does
not understand `outputFile`.
---
If your project is set up for it, you can reply to this emai
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-134167836
Ah I see. So the release plugin isn't going to know about the updated
output path to the shade plugin? then I completely agree it has to change as it
won't work otherwise
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133970773
I think I understand the problem and the fix strategy sounds good to me.
But I will leave it @srowen to LGTM this as he is more well-versed with pom
stuff than I am.
---
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133798583
E.g., in 1.5.0-rc1, for the kafka-assembly project, maven will generate a
jar without any codes except some meta files in the target folder, see
https://repository.apach
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133798330
No, I'm wondering why the output path has to change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133798169
I'm not sure if we can change the output path for SBT. By default, it will
put all generated files in `target/scala-***/` folder, since it supports to
build artifacts fo
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133797893
> @zsxwing yes but the point is that it is now different from the SBT
output path. Why is it required that these be different? It's possible, but I
think it needs a moti
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133796304
@zsxwing yes but the point is that it is now different from the SBT output
path. Why is it required that these be different? It's possible, but I think it
needs a motivat
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133791989
@jerryshao see https://issues.apache.org/jira/browse/SPARK-10168 If we set
the output path, there will be still a jar in the target folder and maven will
publish it rath
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133776146
The code LGTM.
A simple question: any specific reason to change the Maven output file path
back to default? IMHO it would be better to keep this output file p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133725327
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133725287
[Test build #41412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41412/console)
for PR 8373 at commit
[`e0b5818`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133725328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133718320
[Test build #41412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41412/consoleFull)
for PR 8373 at commit
[`e0b5818`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133718050
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133718045
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133717299
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133717300
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133717280
[Test build #41410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41410/console)
for PR 8373 at commit
[`c697627`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133715504
[Test build #41410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41410/consoleFull)
for PR 8373 at commit
[`c697627`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133715371
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133715369
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133713630
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133713631
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133713620
[Test build #41408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41408/console)
for PR 8373 at commit
[`be1d8a5`](https://github.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133713218
CC @jerryshao since in https://github.com/apache/spark/pull/5632/files I
think it was argued that this is on purpose. Also never hurts to CC @vanzin
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133711304
[Test build #41408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41408/consoleFull)
for PR 8373 at commit
[`be1d8a5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133709711
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8373#issuecomment-133709698
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/8373
[SPARK-10168][Streaming]Fix the issue that maven publishes wrong artifact
jars
This PR removed the `outputFile` configuration from pom.xml and updated
`tests.py` to search jars for both sbt build a
33 matches
Mail list logo
