[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-24 Thread yhuai
Github user yhuai closed the pull request at: https://github.com/apache/spark/pull/8379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-24 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-134360026 Thanks guys, merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-24 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-134344274 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133910865 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133910864 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133910841 [Test build #41426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41426/consoleFull) for PR 8379 at commit [`afcfad9`](https://git

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133881088 [Test build #41426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41426/consoleFull) for PR 8379 at commit [`afcfad9`](https://gith

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133880694 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133880702 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133842454 btw I have sent a PR on your branch, let's see if that can work :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133831627 Before 1.5, `ExtractValue` chain may have intermedia and unnecessary `Alias`es inside it, so we trim `Alias`es upon `ExtractValue` before compare 2 `Expression`s in a

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133783622 hmm. seems it triggers another bug? btw, the failed test is `org.apache.spark.sql.SQLQuerySuite.grouping on nested fields`. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133783118 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133783112 [Test build #41418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41418/consoleFull) for PR 8379 at commit [`009aadb`](https://git

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133783117 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133782087 [Test build #41418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41418/consoleFull) for PR 8379 at commit [`009aadb`](https://gith

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133780350 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8379#issuecomment-133780353 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggre...

2015-08-22 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/8379 [SPARK-10169] [SQL] [BRANCH-1.4] Partial aggregation's plan is wrong when a grouping expression is used as an argument of the aggregate fucntion https://issues.apache.org/jira/browse/SPARK-10169 You