Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137865685
@andrewor14 have you merged it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8389#issuecomment-137865664
Deferring to #8584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user marmbrus closed the pull request at:
https://github.com/apache/spark/pull/8389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137803653
OK LGTM I'm merging this into master thanks @marmbrus @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137646360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137646314
[Test build #41988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41988/console)
for PR 8584 at commit
[`6db29b5`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137646358
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137625497
[Test build #41988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41988/consoleFull)
for PR 8584 at commit
[`6db29b5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137623221
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137623206
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38710809
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ParquetHiveCompatibilitySuite.scala
---
@@ -18,38 +18,20 @@
package org.apache.spark.sql.h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137577512
Looks great. There are many places where we still do
`sqlContext.sparkContext` but that's no longer necessary. You can to a search
and replace to clean that up (not a
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38697572
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcPartitionDiscoverySuite.scala
---
@@ -17,19 +17,18 @@
package org.apache.spa
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38697419
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ParquetHiveCompatibilitySuite.scala
---
@@ -18,38 +18,20 @@
package org.apache.spark.sql.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38697136
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -63,7 +63,13 @@ private[sql] trait SQLTestUtils
* but the imp
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38696428
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SortSuite.scala ---
@@ -22,6 +22,7 @@ import org.apache.spark.sql.catalyst.dsl.expressions
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38696385
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExchangeSuite.scala ---
@@ -22,6 +22,8 @@ import
org.apache.spark.sql.catalyst.plans.phys
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38696230
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -29,7 +29,7 @@ class DataFrameStatSuite extends QueryTest with
Shar
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38696123
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38695976
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38694662
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38679843
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38670214
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -36,9 +36,7 @@ trait SharedSQLContext extends SQLTestUtils {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137498564
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137498568
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137498555
[Test build #41975 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41975/console)
for PR 8584 at commit
[`0faa5ba`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137498051
[Test build #41975 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41975/consoleFull)
for PR 8584 at commit
[`0faa5ba`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137495860
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137495798
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137495484
I think it's cause it renames `ctx` to `sqlContext`, which I think
@marmbrus agrees is a good idea IIRC.
---
If your project is set up for it, you can reply to this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137494808
There is compilation error in InMemoryColumnarQuerySuite. Also, why this PR
has significantly more changes than the original one?
---
If your project is set up for it, yo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137485449
[Test build #41973 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41973/console)
for PR 8584 at commit
[`a9ae3f5`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137485509
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137485508
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137479866
cc @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137479647
[Test build #41973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41973/consoleFull)
for PR 8584 at commit
[`a9ae3f5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137479069
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137479089
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137478877
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38654286
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137473878
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137473880
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137473158
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137473144
[Test build #41970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41970/console)
for PR 8584 at commit
[`41a5f90`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137473162
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8584#discussion_r38653456
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -36,9 +36,7 @@ trait SharedSQLContext extends SQLTestUtils {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137471493
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137471504
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137472008
[Test build #41970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41970/consoleFull)
for PR 8584 at commit
[`41a5f90`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137468435
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137468486
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137467052
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137467002
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137465818
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8584#issuecomment-137465842
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/8584
[SPARK-10176][SQL] Show partially analyzed plans when checkAnswer fails to
analyze
This PR takes over https://github.com/apache/spark/pull/8389.
This PR improves `checkAnswer` to print th
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38619104
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -273,6 +273,10 @@ object SparkSQLConfTest extends Logging {
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8389#issuecomment-137262771
Hi @marmbrus @cloud-fan all my comments are minor and this is mergeable as
is, but I have two high level comments:
(1) I think we should always put `with Test
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592397
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -25,16 +27,8 @@ import org.apache.spark.sql.{Row, SQLConf, QueryTe
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592440
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveOperatorQueryableSuite.scala
---
@@ -17,13 +17,14 @@
package org.apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592416
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala ---
@@ -18,22 +18,20 @@
package org.apache.spark.sql.hive
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592348
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592233
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ParquetHiveCompatibilitySuite.scala
---
@@ -23,13 +23,12 @@ import java.util.{Locale, TimeZone
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592181
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ListTablesSuite.scala ---
@@ -19,12 +19,12 @@ package org.apache.spark.sql.hive
impo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592158
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -51,6 +51,11 @@ object TestHive
// SPARK-8910
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38592048
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -39,10 +39,8 @@ import org.apache.spark.util.Utils
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591968
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -39,10 +39,8 @@ import org.apache.spark.util.Utils
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591900
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -35,7 +35,7 @@ case class TestData(key: Int, value: Stri
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591851
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -273,6 +273,10 @@ object SparkSQLConfTest extends Logging {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591695
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSuite.scala ---
@@ -17,15 +17,15 @@
package org.apache.spark.sql.hive
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591674
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
---
@@ -52,8 +52,10 @@ class HiveMetastoreCatalogSuite extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591631
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameWindowSuite.scala
---
@@ -17,13 +17,14 @@
package org.apache.spark.sql
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8389#discussion_r38591627
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameJoinSuite.scala
---
@@ -17,11 +17,12 @@
package org.apache.spark.sql.h
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8389#issuecomment-136063224
@andrewor14 this is ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/8389
[SPARK-10176][SQL] Show partially analyzed plans when checkAnswer fails to
analyze
This PR improves `checkAnswer` to print the partially analyzed plan in
addition to the user friendly error messag
76 matches
Mail list logo
