Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220193521
No worries!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220193132
@marmbrus Sorry for letting you reverting this, I should have thought of
this further before opening this PR. I will try to think more and try more
carefully.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220192667
Sure, I thought you could reopen PRs you created, but if not feel free to
create a new one and link.
---
If your project is set up for it, you can reply to this
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220188177
@jurriaan Oh, thank you. @marmbrus Yes please. You mea n reopening JIRA (it
seems I can't reopen a merged PR).
---
If your project is set up for it, you can reply
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220177425
I'm going to revert this until we figure out the issues @HyukjinKwon can
you reopen?
---
If your project is set up for it, you can reply to this email and have your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220176423
Thanks for reporting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jurriaan commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-220150712
This breaks writing empty dataframes for me.
Before this PR I could write empty dataframes without any problems.
Now it only writes a _SUCCESS file,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219797464
Thanks, merging to master and 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219635881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219635877
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219635725
**[Test build #58666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58666/consoleFull)**
for PR 12855 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219624016
**[Test build #58666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58666/consoleFull)**
for PR 12855 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12855#discussion_r63466408
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -216,6 +215,33 @@ class InsertIntoHiveTableSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219616350
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219616331
**[Test build #58662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58662/consoleFull)**
for PR 12855 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219616349
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12855#discussion_r63462283
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
---
@@ -879,6 +879,24 @@ abstract class HadoopFsRelationTest
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12855#discussion_r63462262
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -216,6 +215,33 @@ class InsertIntoHiveTableSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219614959
**[Test build #58662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58662/consoleFull)**
for PR 12855 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-219614807
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-218946730
ping @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-218039551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-218039550
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-218039422
**[Test build #58186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58186/consoleFull)**
for PR 12855 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-218027650
**[Test build #58186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58186/consoleFull)**
for PR 12855 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-217757354
Hi @marmbrus , Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216627572
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216509271
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216509273
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216509082
**[Test build #57625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57625/consoleFull)**
for PR 12855 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216502970
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216502973
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216502802
**[Test build #57624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57624/consoleFull)**
for PR 12855 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12855#discussion_r61863843
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala
---
@@ -363,84 +365,87 @@ private[sql] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12855#discussion_r61863848
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala
---
@@ -363,84 +365,87 @@ private[sql] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12855#discussion_r61863832
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala
---
@@ -239,48 +239,50 @@ private[sql] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216492627
**[Test build #57625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57625/consoleFull)**
for PR 12855 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216491865
**[Test build #57624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57624/consoleFull)**
for PR 12855 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216491871
@rxin I could find the same issue in internal datasources. I just added the
same logics and a test in `HadoopFsRelationTest `.
---
If your project is set up for
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216436047
@rxin Sure, I will thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216435961
Can you look at it together with this? Seems like a good logical grouping
and arguably data sources are more important than the Hive ones.
---
If your project is set up
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216435745
@rxin I thought so but I haven't tested yet. Could I will look into that if
this one is merged maybe?
---
If your project is set up for it, you can reply to this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216435343
Should we have the same logic for data sources?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216434479
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216434477
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216434410
**[Test build #57587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57587/consoleFull)**
for PR 12855 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216428980
**[Test build #57587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57587/consoleFull)**
for PR 12855 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216422115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216422113
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216421905
**[Test build #57581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57581/consoleFull)**
for PR 12855 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216421825
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216421830
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216421574
**[Test build #57579 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57579/consoleFull)**
for PR 12855 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216412600
**[Test build #57581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57581/consoleFull)**
for PR 12855 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216412075
**[Test build #57579 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57579/consoleFull)**
for PR 12855 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216411956
@yhuai Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12855#issuecomment-216411891
I submitted this PR because #8411 looks abandoned and looks the author is
not answering from the last comment by a commiter. (It has been inactive almost
halt a
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/12855
[SPARK-10216][SQL] Avoid creating empty files during overwrite into Hive
table with group by query
## What changes were proposed in this pull request?
Currently, `INSERT INTO` with
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8411#issuecomment-158553566
@sirpkt Will you have time to bring it up to date? Also, can we add the
same logic in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8411#issuecomment-157165862
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8411#issuecomment-136854363
@yhuai @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8411#issuecomment-134469559
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sirpkt opened a pull request:
https://github.com/apache/spark/pull/8411
[SPARK-10216][SQL]Avoid creating empty files during overwrite into Hive
table with group by query
I added check routine at saveAsHiveFile() of InsertIntoHiveTable.
It checks whether the given
65 matches
Mail list logo
