Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162819270
Thank you for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162803003
Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162447927
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162447923
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162447816
**[Test build #47260 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47260/consoleFull)**
for PR 8534 at commit
[`6831e7a`](https://git
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162440255
I modified the code that was pointed out.
@sarutak @yu-iskw Thank you for reviewing!
---
If your project is set up for it, you can reply to this email and have yo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-162440197
**[Test build #47260 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47260/consoleFull)**
for PR 8534 at commit
[`6831e7a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161952892
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161952894
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161952784
**[Test build #47196 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47196/consoleFull)**
for PR 8534 at commit
[`3743123`](https://git
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161946643
@sarutak thank you for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161943059
**[Test build #47196 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47196/consoleFull)**
for PR 8534 at commit
[`3743123`](https://gith
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161939914
Thank you for reviewing.
I'm modifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user taishi-oss commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46671245
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
Logist
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161777363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161777359
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161776987
**[Test build #47153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47153/consoleFull)**
for PR 8534 at commit
[`4e0a925`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161750998
**[Test build #47152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47152/consoleFull)**
for PR 8534 at commit
[`4e0a925`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161751179
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161751178
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161742016
**[Test build #47153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47153/consoleFull)**
for PR 8534 at commit
[`4e0a925`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161739529
**[Test build #47152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47152/consoleFull)**
for PR 8534 at commit
[`4e0a925`](https://gith
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161738178
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161736518
I've left some comments, otherwise it's LGTM but It's good if @jkbradley or
@mengxr can take a look at.
---
If your project is set up for it, you can reply to this emai
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161735995
ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588189
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -397,22 +413,27 @@ object LogisticRegression extends
Defau
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588122
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -105,11 +119,12 @@ object DecisionTreeClassifier {
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588154
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -165,11 +187,12 @@ object GBTClassifier {
* @param _treeWei
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588033
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -120,10 +126,11 @@ object NaiveBayes extends
DefaultParamsReadable[
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587975
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -121,11 +138,12 @@ object RandomForestClassifier {
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588072
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -71,16 +71,19 @@ private[ml] trait OneVsRestParams extends
Predictor
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46588007
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -174,13 +182,15 @@ class MultilayerPerceptronCl
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587835
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -99,10 +114,12 @@ final class RandomForestClassifier(ov
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -73,10 +73,13 @@ private[ml] trait NaiveBayesParams extends
Predict
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587664
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -39,43 +39,58 @@ import org.apache.spark.sql.functions.
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587620
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -151,29 +155,38 @@ final class OneVsRestModel private[ml] (
* i
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46587368
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -104,19 +104,23 @@ private object LabelConverte
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586993
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -229,8 +240,10 @@ class LogisticRegression(override val uid
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586698
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticR
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586740
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -166,6 +169,7 @@ class LogisticRegression(override val uid:
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586328
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -37,31 +37,43 @@ import org.apache.spark.sql.DataFrame
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586171
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -45,35 +45,46 @@ import org.apache.spark.sql.types.DoubleType
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46586016
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticR
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46585444
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -155,10 +155,13 @@ private[classification] trait
LogisticR
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46583262
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -145,13 +163,17 @@ final class GBTClassifier(override val uid: St
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46582947
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -89,10 +101,12 @@ final class DecisionTreeClassifier(ov
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46581699
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -45,35 +45,46 @@ import org.apache.spark.sql.types.DoubleType
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46579113
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -17,7 +17,7 @@
package org.apache.spark.ml.c
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46579088
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -21,7 +21,7 @@ import java.util.UUID
import scala.language
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46579065
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -19,7 +19,7 @@ package org.apache.spark.ml.clas
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46578992
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -20,7 +20,7 @@ package org.apache.spark.ml.classification
im
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r46578954
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -17,7 +17,7 @@
package org.apache.spark.ml.c
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-161548934
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-159468625
@jkbradley could you run tests for this PR? This is the fist PR for
@taishi-oss.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-159466727
@taishi-oss thank you for the udpate! LGTM
@jkbradley could you take a look at PR?
---
If your project is set up for it, you can reply to this email and have yo
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-156377905
I modified the code that was pointed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-156359833
@yu-iskw Sorry for being late, I'm do right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-156182872
ping @taishi-oss
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-154254270
@taishi-oss thanks for rebaseing master. Could you add `@Since` to all
public variables?
---
If your project is set up for it, you can reply to this email and have you
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093689
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -71,16 +71,19 @@ private[ml] trait OneVsRestParams extends
Predictor
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093643
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -103,11 +116,12 @@ object DecisionTreeClassifier {
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093665
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -390,8 +404,9 @@ class LogisticRegression(override val uid:
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093682
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -110,8 +116,9 @@ class NaiveBayes(override val uid: String)
*
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093684
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -110,8 +116,9 @@ class NaiveBayes(override val uid: String)
*
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093668
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -390,8 +404,9 @@ class LogisticRegression(override val uid:
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093642
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -103,11 +116,12 @@ object DecisionTreeClassifier {
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r44093654
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -165,8 +185,9 @@ object GBTClassifier {
* @param _treeWeigh
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-153612968
Sorry for being late.
I rebased this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-152881764
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-152868076
@hiross thank you for your contribution. Could you update this PR? After
that, I could review it.
---
If your project is set up for it, you can reply to this email and
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-141008317
I think DecisionTreeClassifer.copy is introduced in v1.5.0.
but, This method is brought into v.1.4.1 using "git-cherry-pick".
So "git blames" says v.1.5.0 but "
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140677301
@mengxr Could you take a look?
Now, I'm adding Since annotation to ml.classification.
I think DecisionTreeClassifer.copy is introduced in [this
commit](ht
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140449400
Hmm I actually don't know the answer to that, maybe @mengxr can help
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140334039
I think [that
commit](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2)
is right.
but "git show" command results as follows.
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140182675
I believe the `copy` overrides were added by [this
commit](https://github.com/taishi-oss/spark/commit/43c7ec6384e51105dedf3a53354b6a3732cc27b2)
which went in to 1.5
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-140026675
Sorry, I misunderstood.
I check when all methods were introduced and modify it.
(use SPARK-7751 as a reference.)
If it is not my mistake, DecisionTreeC
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-139311013
Not all methods in a file were introduced in the same version (e.g. see my
comment about DecisionTreeClassifer.copy). Can you make sure that the
annotation versions
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r39184933
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -90,6 +92,9 @@ final class DecisionTreeClassifier(
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-139308325
@taishi-oss no worries, thank you for your help! reviewing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r39184277
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -87,10 +98,12 @@ final class DecisionTreeClassifie
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-139132076
I'm sorry for taking your time.
I modified the code that was pointed out.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-138616552
I only pointed out the issues in the first few files, do you mind fixing
them in all the files?
---
If your project is set up for it, you can reply to this email a
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r38945344
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -35,6 +35,8 @@ import org.apache.spark.sql.DataFra
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r38945223
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -90,6 +92,9 @@ final class DecisionTreeClassifier(
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r38945200
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -90,6 +92,9 @@ final class DecisionTreeClassifier(
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8534#discussion_r38944990
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -35,6 +35,8 @@ import org.apache.spark.sql.DataFra
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-138488219
Sorry for being late.
I modified @since annotations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-136513498
@taishi-oss these were already in spark prior to 1.6, please see the
[parent JIRA](https://issues.apache.org/jira/browse/SPARK-7751) for how to
track down the corre
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8534#issuecomment-136307174
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user taishi-oss opened a pull request:
https://github.com/apache/spark/pull/8534
[SPARK-10259] [ML] Add @since annotation to ml.classification
Add @since annotation to ml.classification
You can merge this pull request into a Git repository by running:
$ git pull https://
91 matches
Mail list logo
