Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173420746
Thank you for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8935
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173337365
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173335838
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173335836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173335649
**[Test build #49798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49798/consoleFull)**
for PR 8935 at commit
[`06a5272`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173324227
**[Test build #49798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49798/consoleFull)**
for PR 8935 at commit
[`06a5272`](https://gith
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173322151
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173107263
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173033564
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173033563
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173033439
**[Test build #49715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49715/consoleFull)**
for PR 8935 at commit
[`06a5272`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173010615
**[Test build #49715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49715/consoleFull)**
for PR 8935 at commit
[`06a5272`](https://gith
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173007683
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173007455
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-167196430
I modified some mistakes that was pointed out in #8534.
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-161544658
in Pipeline.scala, I have some questions.
1.
for example, Pipeline.fit was introduced in v1.2.0.
but, signature was changed in v1.4.0
``
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-161544578
@yu-iskw Sorry for being late, I modify my miss and add anotation to all
public class, object, methods, and variables.
---
If your project is set up for it, you can
Github user taishi-oss commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r46520868
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging
{
*
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-159467655
@taishi-oss thank you for your contribution. Could you modify this PR like
https://github.com/apache/spark/pull/8534? We should add the annotation to all
public class/ob
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-159466857
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-153615685
Sorry for being late.
I rebased this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-152881784
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-152027157
@hiross sorry for the delay of my response. Can you rebase your branch? It
seems that there are any conflicts with the master. So, we can't merge your PR
with the master
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-152026373
Sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-151376098
@hiross Sorry for my slow response! Please check the public API instead of
line changes. The former is more accurate. The PR has merge conflicts with the
master branch. C
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r43084418
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging
{
* an
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r43084419
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging
{
* an
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r43084417
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging
{
* an
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-144666719
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-144101800
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user taishi-oss opened a pull request:
https://github.com/apache/spark/pull/8935
[SPARK-10263] [ML] Add @Since annotation to ml.param and ml.*
Add Since annotations to ml.param and ml.*
You can merge this pull request into a Git repository by running:
$ git pull https://
32 matches
Mail list logo
