Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154177332
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154151243
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154151245
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154151067
**[Test build #45128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45128/consoleFull)**
for PR 8728 at commit
[`55e1317`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154140328
**[Test build #45128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45128/consoleFull)**
for PR 8728 at commit
[`55e1317`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154139272
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154139248
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-154138819
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153906859
@mengxr there is something wrong with Jenkins. It failed to fetch source
code from github 3 times in a row. Could you help us?
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153905986
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153905988
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153903294
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153903312
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153902335
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153899835
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153899841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153896297
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153896259
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153895946
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153895272
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153895275
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153895041
@ehsanmok no problem. I appreciate your first contribution!
@mengxr LGTM
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153892978
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153892975
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153892828
**[Test build #45047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45047/consoleFull)**
for PR 8728 at commit
[`fa61502`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153891925
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153891892
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user ehsanmok commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153891847
@yu-iskw Thank you very much for your patients. I wouldn't have imagined
how much I would learn by doing this starter task.
---
If your project is set up for it, you c
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153887067
@ehsanmok thanks for the update!
- Add `@Since` to `totalIterations`. It seems to be a public variable.
https://github.com/ehsanmok/spark/blob/fa6150269fa52
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153882390
**[Test build #45047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45047/consoleFull)**
for PR 8728 at commit
[`fa61502`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153879517
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153879421
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153860003
@ehsanmok
- `DecisionTreeRegressionModel ` is a public class. The constructor
paramter is `private[ml]`.
- `GBTRegressionModel ` and so on are also public classe
Github user ehsanmok commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153855038
@yu-iskw Thanks for the correction. I think, `DecisionTreeRegressionModel`
is a private[ml] class, right? so does `GBTRegressionModel`,
`IsotonicRegressionModel`, `Line
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153850972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153850968
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153850822
**[Test build #45042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45042/consoleFull)**
for PR 8728 at commit
[`beaa3aa`](https://git
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153849139
@ehsanmok thanks for the update. We should dd `@Since` to public classes
and public methods
- `DecisionTreeRegressionModel`
- `GBTRegressionModel`
- `Isotonic
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8728#discussion_r43932479
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -321,6 +329,7 @@ class LinearRegression(override val uid: String)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153840653
**[Test build #45042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45042/consoleFull)**
for PR 8728 at commit
[`beaa3aa`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153838240
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153838198
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8728#discussion_r43838989
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -36,30 +36,31 @@ import org.apache.spark.sql.DataFrame
Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/8728#discussion_r43838943
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -36,30 +36,31 @@ import org.apache.spark.sql.DataFrame
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153556500
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153556498
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153556398
**[Test build #44989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44989/consoleFull)**
for PR 8728 at commit
[`175d75e`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153550483
**[Test build #44989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44989/consoleFull)**
for PR 8728 at commit
[`175d75e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153548968
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153549014
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153176304
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153176308
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153176297
**[Test build #44842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44842/consoleFull)**
for PR 8728 at commit
[`4f7c36f`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153175727
**[Test build #44842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44842/consoleFull)**
for PR 8728 at commit
[`4f7c36f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153175349
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153175288
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153175372
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-153175231
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-152025714
@mengxr can you run the test when you have time.
BTW, does everyone have the privilege to run tests in this case?
---
If your project is set up for it, you can repl
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-152021748
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user ehsanmok commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-152015083
@yu-iskw should be fine now. Please test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-151987168
@ehsanmok it depends on the situation. Since I don't know what kind of
files appeared as unmerged files, it's hard to decide if you need to add them
or not.
---
If you
Github user ehsanmok commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-151973597
@yu-iskw Thank you very much for the detailed explanations! I just want to
make sure that when I resolve the conflicts (also "Scalastyle checks passed")
and do `git reb
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-151962011
@ehsanmok according to the above warning message, we have any conflicts
with the master. So I'd like to explain how to resolve that. And I'd like to
review this PR after
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-151951744
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-151944005
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8728#issuecomment-139690155
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user ehsanmok opened a pull request:
https://github.com/apache/spark/pull/8728
[SPARK-10265][Documentation, ML] Fixed @Since annotation to ml.regression
Here is my first commit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.c
69 matches
Mail list logo
