Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-155197160
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154911196
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154911156
**[Test build #45334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45334/consoleFull)**
for PR 8690 at commit
[`1fd50b8`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154909354
**[Test build #45334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45334/consoleFull)**
for PR 8690 at commit
[`1fd50b8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154908521
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154908533
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154904899
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154904830
**[Test build #45322 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45322/consoleFull)**
for PR 8690 at commit
[`2c71cc2`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154886308
**[Test build #45322 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45322/consoleFull)**
for PR 8690 at commit
[`2c71cc2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154885841
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154885831
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154885652
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154885616
@noel-smith thanks you for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-154882353
@yu-iskw Thanks for making the changes - LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152849703
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152849692
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152849701
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152849693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152849671
**[Test build #44762 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44762/consoleFull)**
for PR 8690 at commit
[`2c71cc2`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152849659
**[Test build #44763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44763/consoleFull)**
for PR 8690 at commit
[`2c71cc2`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848875
**[Test build #44763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44763/consoleFull)**
for PR 8690 at commit
[`2c71cc2`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848852
**[Test build #44762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44762/consoleFull)**
for PR 8690 at commit
[`2c71cc2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848645
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848657
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848582
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848385
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848369
@noel-smith thank you for the review. I rebase this PR with the mater and
then updated two parts.
- Add `@since` tags to `BGTClassifier` class and object
- A
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-152848393
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150954098
@yu-iskw Almost there - you're just missing the version numbers on
`GBTClassifier` class + methods (they should all be set to `1.4.0`), everything
else looks good tho
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150379119
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150379121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150379000
**[Test build #44183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44183/consoleFull)**
for PR 8690 at commit
[`eef61c6`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150376605
**[Test build #44183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44183/consoleFull)**
for PR 8690 at commit
[`eef61c6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150376436
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150376443
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150375830
@noel-smith thank you for the review. I added them again. Could you review
it?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-150023630
@yu-iskw Thanks for removing those methods - but did you loose some of the
version numbers when rebasing? I.e. ```DecisionTreeClassifier.getImpurity()```
has a ```@si
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149769876
@noel-smith I have rebase and remove the methods which had been already
removed. Could you review it?
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149769495
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149769493
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149769438
**[Test build #44032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44032/consoleFull)**
for PR 8690 at commit
[`226a05f`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149768162
**[Test build #44032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44032/consoleFull)**
for PR 8690 at commit
[`226a05f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149767248
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149767205
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149767234
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149766908
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149766907
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149766092
**[Test build #44031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44031/consoleFull)**
for PR 8690 at commit
[`226a05f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149765235
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149765219
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-149765204
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141213397
The comments on `MultilayerPerceptronClassifier` +
`MultilayerPerceptronClassifierModel` are good. Just need to remove the four
functions noted above (these were dele
Github user noel-smith commented on a diff in the pull request:
https://github.com/apache/spark/pull/8690#discussion_r39791016
--- Diff: python/pyspark/ml/classification.py ---
@@ -116,6 +120,37 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141126346
@noel-smith New PRs should come along with `@since`. I forgot that for MLPC
Python API. @yu-iskw Could you rebase master?
---
If your project is set up for it, you can r
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141035449
[Test build #42586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42586/console)
for PR 8690 at commit
[`970ae03`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141035514
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141035516
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141013027
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141013030
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141012759
[Test build #42590 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42590/console)
for PR 8690 at commit
[`29950fd`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141005722
[Test build #42590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42590/consoleFull)
for PR 8690 at commit
[`29950fd`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141005176
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141005165
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-141005114
@noel-smith @mengxr I have merged this PR with master and have added the
version info. to MultilayerPerceptronClassifier and
MultilayerPerceptronClassificationModel whic
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-140995503
[Test build #42586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42586/consoleFull)
for PR 8690 at commit
[`970ae03`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-140995239
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-140995258
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-140856366
Some functions have been removed since this PR was created + there are some
new classes (`MultilayerPerceptronClassifier`) without version numbers.
@mengxr Ho
Github user noel-smith commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-140853730
Should replace `.. addedversion::` with `.. versionadded::` in all the
class docstrings.
---
If your project is set up for it, you can reply to this email and have y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-139165336
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-139165333
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-139165236
[Test build #42253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42253/console)
for PR 8690 at commit
[`0d99336`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-139161139
[Test build #42253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42253/consoleFull)
for PR 8690 at commit
[`0d99336`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-139160135
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8690#issuecomment-139160035
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user yu-iskw opened a pull request:
https://github.com/apache/spark/pull/8690
[SPARK-10280][MLlib][PySpark][Docs] Add @since annotation to
pyspark.ml.classification
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yu-iskw/
77 matches
Mail list logo
