Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138672312
Thanks, merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8486
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138412857
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138412855
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138412807
[Test build #42108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42108/console)
for PR 8486 at commit
[`b44f74b`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138398769
[Test build #42108 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42108/consoleFull)
for PR 8486 at commit
[`b44f74b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138397668
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-138397610
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136662615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136662613
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136662502
[Test build #41863 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41863/console)
for PR 8486 at commit
[`b544706`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136623325
[Test build #41863 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41863/consoleFull)
for PR 8486 at commit
[`b544706`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136620710
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136620755
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8486#discussion_r38393705
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -26,27 +24,6 @@ import org.apache.spark.sql.catalyst.pla
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136518354
Where possible, I think its good to reduce coupling between these two
components. There are also cases where we have used `PhysicalOperation` before
the optimizer. So
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136420899
My thought is that: If there is no non-deterministic expressions, we will
always push down `Filter` through `Project`, and we will always combine
adjacent `Filter`s an
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-136036533
This patch seems to do significantly more than it claims in the
description. Why not just avoid collapsing projections that have
non-determistic expressions in them.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135632555
cc @rxin @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135496815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135496445
[Test build #41690 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41690/console)
for PR 8486 at commit
[`16ae7e2`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135496813
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135460635
[Test build #41690 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41690/consoleFull)
for PR 8486 at commit
[`16ae7e2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135458247
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135458320
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8486#discussion_r38103673
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -26,83 +24,28 @@ import org.apache.spark.sql.catalyst.pl
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/8486
[SPARK-10316][SQL] respect nondeterministic expressions in PhysicalOperation
We did a lot of special handling for non-deterministic expressions in
`Optimizer`. However, `PhysicalOperation` just co
27 matches
Mail list logo
