Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145045736
[Test build #1837 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1837/consoleFull)
for PR 8758 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145078200
A couple of remaining minor things and this should be good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r41039423
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerArgumentsSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r41039339
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -30,28 +30,36 @@ private[history] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r41039388
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -30,28 +30,36 @@ private[history] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r41050208
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -30,28 +30,36 @@ private[history] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145083214
[Test build #1837 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1837/console)
for PR 8758 at commit
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145134027
done.please have a look. thanks @vanzin @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145136131
[Test build #43194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43194/consoleFull)
for PR 8758 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145139986
Looking strong. This is a good fix / cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145134385
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145134420
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145168672
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145168673
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145168567
[Test build #43194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43194/console)
for PR 8758 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-145169878
Alright, merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144939904
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144939860
[Test build #43172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43172/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144939905
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144940233
[Test build #43173 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43173/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144940323
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144940329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144941702
Unrelated errors.
```
[error] SERVER ERROR: Service Temporarily Unavailable
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144706624
Yeah, the current script does blindly 'pass' the first arg as an
environment variable. It never parsed any args at all to the arg-parsing code,
which seems like an
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144738730
Aha you're right about "1". It can stay:
```
usage="Usage: spark-daemon.sh [--config ]
(start|stop|submit|status) "
```
Yes it doesn't pass args now but
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144732338
You guys are misinterpreting the script.
That `1` is not an argument to the HistoryServer, it's an argument to
`spark-daemon.sh`. The script never passes any
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144740121
The change in `start-history-server.sh` adds the command line parameters,
and those are propagated to the java process. That part of the change is fine.
The
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144741977
Good, yes passing through the args is right. Right now if you run
`start-history-server.sh foo` you will successfully set the log directory to
foo because of what the
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144742060
Hmm, I think I get what you're trying to do. You're trying to implement the
script's command line handling in `HistoryServerArguments` (the old `if [ $# !=
0 ]; then`
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144749562
Hi, me again. Looking at the code once more, I think it's ok if you want to
make this change in the scala code and not the shell script (so, e.g., you can
unit test it),
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144796916
I like that better since it focuses narrowly on supporting one arg.
@rekhajoshm what do you think? the rest looks good.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144863825
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144864876
[Test build #43163 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43163/consoleFull)
for PR 8758 at commit
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144863677
makes sense.good discussion @vanzin @srowen .updated.please review.thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144863801
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144890337
[Test build #43163 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43163/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144890390
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144890391
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40984139
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -30,25 +30,33 @@ private[history] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40984429
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerArgumentsSuite.scala
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40984442
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerArgumentsSuite.scala
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144892549
Logic now looks good, just a few minor things to take care of.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40984625
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerArgumentsSuite.scala
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144915880
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144915869
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144916290
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144916294
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144913260
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144913245
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144914254
updated.kind of know @vanzin needs parseOtherArgs() to be named differently
:-) please let me know. thanks @vanzin @srowen !
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144916134
[Test build #43172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43172/consoleFull)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144921942
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144921958
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144922101
[Test build #43173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43173/consoleFull)
for PR 8758 at commit
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144922099
unrelated error.
```
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from
https://github.com/apache/spark.git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144321000
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144320895
[Test build #43120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43120/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144320999
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144323299
[Test build #43121 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43121/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144323391
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144326057
[Test build #43122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43122/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144323389
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144326226
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144326228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144604656
Thanks for your comments @vanzin !
However that does not seem an accurate assessment.Before this patch, the
script accepted only first parameter and set it to
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40796335
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -48,7 +48,11 @@ private[history] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144288227
[Test build #43122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43122/consoleFull)
for PR 8758 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144287610
[Test build #43121 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43121/consoleFull)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144287387
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144286924
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144286887
unrelated error.ERROR: Publisher 'Publish JUnit test result report' failed:
No test report files were found. Configuration error?
Build succeeded locally.
```
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144283815
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144283818
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144284986
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144285014
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144286950
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144286929
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144287146
Thanks @srowen .I was earlier doing counters logic(below) to validate only
if first param in HSArguments and it seemed not as clean/intentful as the
script. Hence
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144282191
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144282175
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144282755
[Test build #43119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43119/consoleFull)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144285583
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144285521
[Test build #43120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43120/consoleFull)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144285582
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144285562
[Test build #43119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43119/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144281792
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144281804
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144287378
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143920069
thanks for your comment @srowen . i had tried that earlier, it did not seem
cleaner to me with the understanding that this is only for backward
compatibility and
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143930452
I see, `HistoryServerArguments` doesn't actually parse the final arg
already. I think it could easily; `case _ =>` just also sets the 'dir' argument
but issues a
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40491206
--- Diff: sbin/start-history-server.sh ---
@@ -30,10 +30,11 @@ sbin="`cd "$sbin"; pwd`"
. "$sbin/spark-config.sh"
.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143409007
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143408984
[Test build #43047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43047/console)
for PR 8758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143409008
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143400142
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143400118
The error is not related to this pull
```
[error] SERVER ERROR: Service Temporarily Unavailable
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143400127
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143400137
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-143400329
[Test build #43047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43047/consoleFull)
for PR 8758 at commit
1 - 100 of 168 matches
Mail list logo
