Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138789555
@mengxr Sorry for the extra effort during review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hhbyyh closed the pull request at:
https://github.com/apache/spark/pull/8650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138726975
Ok, I'll merge in the doc tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138714699
@holdenk Yes, I just noticed it. Could you merge some changes in this PR
into yours? I think the doctest from @hhbyyh is better and the default values
are specified corre
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138704510
This seems to do the same work as the outstanding PR
https://github.com/apache/spark/pull/8561
---
If your project is set up for it, you can reply to this email and ha
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138680688
LGTM except some minor issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8650#discussion_r38962140
--- Diff: python/pyspark/ml/feature.py ---
@@ -167,6 +168,134 @@ def getSplits(self):
@inherit_doc
+class CountVectorizer(JavaEstimator, Ha
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8650#discussion_r38962082
--- Diff: python/pyspark/ml/feature.py ---
@@ -167,6 +168,134 @@ def getSplits(self):
@inherit_doc
+class CountVectorizer(JavaEstimator, Ha
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8650#discussion_r38962137
--- Diff: python/pyspark/ml/feature.py ---
@@ -167,6 +168,134 @@ def getSplits(self):
@inherit_doc
+class CountVectorizer(JavaEstimator, Ha
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8650#discussion_r38962078
--- Diff: python/pyspark/ml/feature.py ---
@@ -167,6 +168,134 @@ def getSplits(self):
@inherit_doc
+class CountVectorizer(JavaEstimator, Ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138468566
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138468472
[Test build #42125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42125/console)
for PR 8650 at commit
[`dd0e933`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138468564
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138465382
[Test build #42125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42125/consoleFull)
for PR 8650 at commit
[`dd0e933`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138464930
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138464950
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138459078
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138459076
[Test build #42122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42122/console)
for PR 8650 at commit
[`d22ba5a`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138459077
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138459005
[Test build #42122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42122/consoleFull)
for PR 8650 at commit
[`d22ba5a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138458014
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138458027
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138411896
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138411895
[Test build #42112 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42112/console)
for PR 8650 at commit
[`0f1fa34`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138411897
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138411847
[Test build #42112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42112/consoleFull)
for PR 8650 at commit
[`0f1fa34`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138411639
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8650#issuecomment-138411647
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/8650
[SPARK-10482] [ML] Add Python interface for ml.CountVectorizer
jira: https://issues.apache.org/jira/browse/SPARK-10482
Add Python interface for feature transformer: ml.CountVectorizer
You ca
29 matches
Mail list logo
