Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-149980991
Thank you! Merging to master and 1.5 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-149790801
ping @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148519127
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148519131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148518898
[Test build #43802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43802/console)
for PR 9123 at commit
[`4f162ed`](https://github.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148512630
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148512143
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148512142
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148511879
[Test build #43796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43796/console)
for PR 9123 at commit
[`9ed26d1`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148487314
[Test build #43802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43802/consoleFull)
for PR 9123 at commit
[`4f162ed`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148487000
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148486845
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148486974
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148484237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148484236
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148484150
[Test build #43798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43798/console)
for PR 9123 at commit
[`4f162ed`](https://github.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148484211
LGTM pending test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148480193
[Test build #43798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43798/consoleFull)
for PR 9123 at commit
[`4f162ed`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148479594
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148479569
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148476915
[Test build #43796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43796/consoleFull)
for PR 9123 at commit
[`9ed26d1`](https://gith
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148476166
hi @dilipbiswal , can you update the PR title to make it a complete
sentence(i.e. no ellipsis)? and can you also put my explaination of this bug in
PR description? so
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148475647
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148475604
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42158784
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -135,4 +135,14 @@ class AnalysisSuite extends Analy
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42158115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -482,7 +482,9 @@ class Analyzer(
val newOrder
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148342508
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148342506
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148342359
[Test build #43778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43778/console)
for PR 9123 at commit
[`6f97fb7`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148335402
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148335401
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148335260
[Test build #43776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43776/console)
for PR 9123 at commit
[`ac78af1`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148314896
[Test build #43778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43778/consoleFull)
for PR 9123 at commit
[`6f97fb7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148314571
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148314559
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148314200
@cloud-fan
Hi Wenchen, i have fixed the code based on your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42092689
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -135,4 +135,21 @@ class AnalysisSuite extends Ana
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42092649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -482,7 +482,12 @@ class Analyzer(
val newOr
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148307180
[Test build #43776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43776/consoleFull)
for PR 9123 at commit
[`ac78af1`](https://gith
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42091740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -482,7 +482,12 @@ class Analyzer(
val newOrde
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148306682
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148306706
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148306333
I wanna explain a bit more about this bug.
When we resolve sort ordering, we will use a [special
method](https://github.com/apache/spark/blob/master/sql/cataly
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148306360
ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9123#discussion_r42089770
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -135,4 +135,21 @@ class AnalysisSuite extends Analy
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148220968
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9123#issuecomment-148220723
@cloud-fan
Can you please take a look. Thanks ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/9123
[SPARK-10534][SQL] ORDER BY clause allows only columns that are present in
Sâ¦
Find out the missing attributes by recursively looking
at the sort order expression and rest of the code
t
49 matches
Mail list logo