[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-142060234 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141816181 Sounds good, there's a logic to it then, gotcha. I figured as much. Leave it, of course. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-20 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141815598 @srowen : So the implicit tag is needed because the signature for this one is different (all the other ones are calling concrete types and this is a templated type).

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141814077 I'm looking at https://github.com/apache/spark/pull/8841 now, for comparison, and noted that the Java overloads there call the scala overloads directly, rather than call

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141561089 So I created https://issues.apache.org/jira/browse/SPARK-10706 to add random vector wrapper for the Java API as well and I'll follow up with that in a bit. --- If your

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141546779 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141546783 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141546494 [Test build #42677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42677/console) for PR 8782 at commit [`dae7346`](https://github.

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141536508 I don't have a strong opinion on it. It looks like there is this parallel structure for everything except the random and random-vector methods, for some reason. But yeah

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141534938 [Test build #42677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42677/consoleFull) for PR 8782 at commit [`dae7346`](https://gith

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141533488 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141533463 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-18 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141532528 @srowen I figured providing a general method would be easier than playing whack-a-mole with all of the other wrapper methods, but I can either add vector to this one or

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-141020339 LGTM because it looks like the other Scala RDD utility methods have Java parallels here too. How about the random vector RDD method too? --- If your project is set

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8782#discussion_r39725671 --- Diff: mllib/src/test/java/org/apache/spark/mllib/random/JavaRandomRDDsSuite.java --- @@ -231,4 +232,30 @@ public void testGammaVectorRDD() { }

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140941481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140941483 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140941425 [Test build #42568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42568/console) for PR 8782 at commit [`170c940`](https://github.

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140938535 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140938538 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140938441 [Test build #42564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42564/console) for PR 8782 at commit [`d1c2323`](https://github.

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140938320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140938319 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140938237 [Test build #42563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42563/console) for PR 8782 at commit [`bdd886d`](https://github.

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140936442 [Test build #42568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42568/consoleFull) for PR 8782 at commit [`170c940`](https://gith

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140935648 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10626][MLLIB] create java friendly meth...

2015-09-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8782#issuecomment-140935660 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have