Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-146356551
LGTM. Merged into master. Sorry for the delay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8853
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144321113
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144321093
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144331242
[Test build #43126 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43126/console)
for PR 8853 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144331374
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144331370
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40767420
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -541,36 +536,38 @@ private class LeastSquaresAggregator(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144322508
[Test build #43126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43126/consoleFull)
for PR 8853 at commit
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40767083
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -20,6 +20,7 @@ package
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40767101
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.ml.regression
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144101215
I know `ml.feature` is mostly for feature engineering, but I don't think
`ml.util` is a good place. How about make it as first citizen in `ml`? I will
implement
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40754590
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -20,6 +20,7 @@ package
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40754595
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.ml.regression
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144266021
Okay. It makes sense. But it's still private, and cleans up some code, do u
think it worths to merge it first and we can think about where is the best
place to have it?
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40754661
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -541,36 +536,38 @@ private class LeastSquaresAggregator(
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144259441
It will be quite hard, e.g., in survival model, we have a column called
`censor`. In the future, we might want to add `offset` to instances used in
linear models.
---
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40754635
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -541,36 +536,38 @@ private class LeastSquaresAggregator(
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-143951133
@dbtsai The main question would be where we should put `Instance`. I'm not
sure `ml.feature` is a good place for it, though I don't have good
alternatives. Another place
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142129790
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142131942
[Test build #42785 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42785/consoleFull)
for PR 8853 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142140129
[Test build #42785 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42785/console)
for PR 8853 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142129812
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142140335
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142140331
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142121937
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142121954
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-14216
[Test build #42781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42781/consoleFull)
for PR 8853 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142122681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142122675
[Test build #42781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42781/console)
for PR 8853 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-142122682
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/8853
[SPARK-10738][ML] Refactoring `Instance` out from LOR and LIR, and also
cleaning up some code
Refactoring `Instance` case class out from LOR and LIR, and also cleaning
up some code.
You can merge
32 matches
Mail list logo
