[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215305404 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215305403 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215305352 **[Test build #57210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57210/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215303378 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215303382 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215303315 **[Test build #57209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57209/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215301197 **[Test build #57210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57210/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-215298976 **[Test build #57209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57209/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-27 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61368867 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedGeneralTypeParams.scala --- @@ -0,0 +1,34 @@ +/* --- End diff --

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61018699 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -274,6 +339,12 @@ class KMeans @Since("1.5.0") (

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61018493 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedGeneralTypeParams.scala --- @@ -0,0 +1,34 @@ +/* --- End diff -- I

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61018069 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -258,6 +290,27 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61017723 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -198,6 +231,17 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61017539 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -171,12 +192,23 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61017075 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,17 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213607193 @jkbradley @mengxr I updated the MLReadable/MLWritable to previous DefaultMLReadable/DefaultMLWritable to prevent Mima failure. Can we catch it in 2.0? --- If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213601396 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213601390 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213601096 **[Test build #56736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56736/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213591686 **[Test build #56736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56736/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213585811 **[Test build #56734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56734/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213585829 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213585826 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-213583913 **[Test build #56734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56734/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-16 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210752633 retest it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-16 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210752849 @jkbradley @MLnick It's strange that the PR failed Mima test. Do you have any thoughts about it? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210649354 This will be very useful for many use cases. Nice to have it in 2.0 :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210645177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210645180 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210645138 **[Test build #55959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55959/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210642358 **[Test build #55959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55959/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210642080 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210640241 @MLnick Ah.. Sorry, my first understanding is wrong. Yeah, we should resurrect it since SPARK-14033 stopped for now. I'll resolve the conflicts soon. --- If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210633691 @yinxusen sorry, I meant we should aim to continue review of this PR and hopefully merge it. Ping @jkbradley @dbtsai @holdenk --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210632085 @MLnick Of course. Go ahead please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-15 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-210619228 @yinxusen since it was decided not to proceed with [SPARK-14033](https://issues.apache.org/jira/browse/SPARK-14033), shall we resurrect this PR? It would be great to

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-23 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-200672196 @jkbradley Sure, I'll leave it here and check back later. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-200657397 @yinxusen Well, I still think we should support initial models, and hopefully some of the code (like unit tests) would be reusable. Feel free to leave this open

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-23 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-200616469 Never mind, let's close this if that one merged. Sent from my iPhone > On Mar 23, 2016, at 18:35, jkbradley wrote: >

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-200607540 Sorry for the delayed review. I'm worried that these PRs to set the initial model may need to change significantly if we merge Estimator & Model:

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-23 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-200559106 @holdenk @dbtsai Any more thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196705344 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196705342 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196705247 **[Test build #53171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53171/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196690788 **[Test build #53171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53171/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196690176 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-15 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196690164 I'll create new JIRA on params overriding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56117376 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -258,6 +290,27 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56115607 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -258,6 +290,27 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196636602 @jkbradley Sure. I'll check them later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110893 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -258,6 +290,27 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196635713 I'm also a fan of overriding other Params, but am Ok with it being in another JIRA & PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110707 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -108,6 +111,21 @@ class KMeansSuite extends SparkFunSuite with

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110698 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -269,6 +322,13 @@ class KMeans @Since("1.5.0") (

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110689 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -196,6 +220,14 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110693 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -258,6 +290,27 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110686 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -169,12 +181,23 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56110697 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -269,6 +322,13 @@ class KMeans @Since("1.5.0") (

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196522129 @dbtsai @MLnick I prepare not to add the parameter overriding feature in this PR since it has other issues related, such as making the `fit()` modify the

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196509889 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196509885 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196509516 **[Test build #53096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53096/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196490346 @dbtsai And as [discussed in the

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-196489505 **[Test build #53096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53096/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r56062024 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -108,6 +111,21 @@ class KMeansSuite extends SparkFunSuite with

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55967102 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -108,6 +113,21 @@ class KMeansSuite extends SparkFunSuite with

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55966718 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -30,11 +33,13 @@ class KMeansSuite extends SparkFunSuite with

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55965910 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -118,6 +138,11 @@ object KMeansSuite {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-14 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55965857 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -118,6 +138,11 @@ object KMeansSuite {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194694816 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194694815 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194694692 **[Test build #52816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52816/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194684818 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55636801 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,17 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194684711 **[Test build #52816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52816/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55636113 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,18 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55632709 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,18 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-09 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55632528 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,18 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194062594 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194062592 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194062283 **[Test build #52711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52711/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194050123 **[Test build #52711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52711/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-08 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-194047596 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55281476 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -169,12 +182,29 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r55276968 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -169,12 +182,29 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193447782 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193447786 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193447571 **[Test build #52591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52591/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193431887 **[Test build #52591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52591/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193398412 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193398396 **[Test build #52578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52578/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193398410 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193397548 **[Test build #52578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52578/consoleFull)** for PR 9 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-03-07 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-193395888 Ping @dbtsai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-02-23 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-187598373 Yes, but busy on work. :( Will soon start it in couple days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-02-22 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-187365420 Ping @dbtsai Coming back? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-02-12 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-183248930 @yinxusen I'll be away for Spark summit east. Gonna work on this again when I'm back. Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-02-12 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-183249963 Never mind, take your time. 2016年2月12日星期五,DB Tsai 写道: > @yinxusen I'll be

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-182772277 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9#issuecomment-182772167 **[Test build #51090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51090/consoleFull)** for PR 9 at commit

  1   2   >