Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r44487354
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -49,8 +49,8 @@ private[spark] class AppClient(
private val REGISTRATIO
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-155540291
LGTM.
CC @rxin to take a final look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153908412
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153908415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153908290
**[Test build #45048 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45048/consoleFull)**
for PR 9317 at commit
[`4f46cfd`](https://git
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153885558
>E.g., requestTotalExecutors is called from SparkDeploySchedulerBackend and
it's not in the thread that setting endpoint and appId.
Got it, thanks!
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153882657
**[Test build #45048 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45048/consoleFull)**
for PR 9317 at commit
[`4f46cfd`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153881518
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153881561
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153881055
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153881057
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153880838
**[Test build #45044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45044/consoleFull)**
for PR 9317 at commit
[`cd5329c`](https://git
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43941797
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -208,13 +213,32 @@ private[spark] class AppClient(
case k
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153869588
> I made this change, but would you mind clarifying a little where these
are shared? From what I can tell, I think the RpcEndpointRef gets wrapped in
the NettyRpcCallCon
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153850908
Thanks for the feedback @zsxwing !
>@BryanCutler Could you also make the following variables volatile? They
are accessed in multiple threads.
> p
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153846633
**[Test build #45044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45044/consoleFull)**
for PR 9317 at commit
[`cd5329c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153845878
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153845912
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43808980
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Founda
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43808865
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Founda
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43808091
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Founda
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43807908
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Founda
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43806884
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Founda
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43806728
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -208,13 +218,28 @@ private[spark] class AppClient(
case k
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153479463
@BryanCutler Could you also make the following variables `volatile`? They
are accessed in multiple threads.
```
private var endpoint: RpcEndpointRef = null
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43802502
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -77,6 +77,16 @@ private[spark] class AppClient(
private val regis
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43800978
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -77,6 +77,16 @@ private[spark] class AppClient(
private val regis
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153471074
Hi @zsxwing , could you take a look at this? There have been some
superficial test failures, but the last one in CoarseMesosSchedulerBackendSuite
looks like it coul
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153465464
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153465459
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153465377
**[Test build #44939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44939/consoleFull)**
for PR 9317 at commit
[`95d2499`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153435577
**[Test build #44939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44939/consoleFull)**
for PR 9317 at commit
[`95d2499`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153434074
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153433990
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153431943
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153131778
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153131781
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153131774
**[Test build #44824 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44824/consoleFull)**
for PR 9317 at commit
[`95d2499`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153130345
**[Test build #44824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44824/consoleFull)**
for PR 9317 at commit
[`95d2499`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153128012
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153127965
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153127474
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153125623
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153125626
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153121675
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-153121649
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152688124
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152688120
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152688093
**[Test build #44722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44722/consoleFull)**
for PR 9317 at commit
[`ab3e929`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152682971
**[Test build #44722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44722/consoleFull)**
for PR 9317 at commit
[`ab3e929`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152682773
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152682766
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152682492
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152680144
bad luck today I guess :(
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152679403
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152679405
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152677208
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152677196
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152677178
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152668218
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152668216
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152668173
**[Test build #44705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44705/consoleFull)**
for PR 9317 at commit
[`5e155cc`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152653227
**[Test build #44705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44705/consoleFull)**
for PR 9317 at commit
[`5e155cc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152652617
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152652595
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152652511
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152624499
Thanks for the feedback @holdenk !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43542555
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Fo
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43541805
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -77,6 +77,16 @@ private[spark] class AppClient(
private val r
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43541649
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -200,7 +210,18 @@ private[spark] class AppClient(
cas
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43533223
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Founda
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43531634
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -77,6 +77,16 @@ private[spark] class AppClient(
private val regis
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43531553
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -200,7 +210,18 @@ private[spark] class AppClient(
case r:
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152597267
Sure thing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152581083
@holdenk if you wouldn't mind taking a look at this, I'd appreciate it!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152351698
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152351699
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152351632
**[Test build #44639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44639/consoleFull)**
for PR 9317 at commit
[`5e155cc`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152332806
**[Test build #44639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44639/consoleFull)**
for PR 9317 at commit
[`5e155cc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152330856
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152330835
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-152330545
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151744807
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151744815
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151744460
**[Test build #44495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44495/consoleFull)**
for PR 9317 at commit
[`5e155cc`](https://git
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/9317#discussion_r43219668
--- Diff:
core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Fo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151727969
**[Test build #44495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44495/consoleFull)**
for PR 9317 at commit
[`5e155cc`](https://gith
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151727488
@zsxwing would you mind checking this out? I noticed there were no
existing unit tests for AppClient, so I added them. I couldn't think of a way
to test that the c
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151727395
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9317#issuecomment-151727380
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/9317
[SPARK-10827] [CORE] AppClient should not use `askWithReply` in
`receiveAndReply`
Changed AppClient to be non-blocking in `receiveAndReply` by using a
separate thread to wait for response and r
92 matches
Mail list logo
