Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41455135
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -245,7 +247,8 @@ private[sql] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146351397
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41439861
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnBuilder.scala ---
@@ -109,16 +113,20 @@ private[sql] class StringColumnBuilder extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146351398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146351273
[Test build #43341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43341/console)
for PR 8971 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41458798
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -88,7 +88,7 @@ final class Decimal extends Ordered[Decimal] with
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146356930
Merged into master. Other nit comments will be addressed by follow up PR,
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146317015
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41458139
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -245,7 +247,8 @@ private[sql] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146317050
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41442531
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -96,11 +101,23 @@ private[sql] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41442678
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -245,7 +247,8 @@ private[sql] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146319179
[Test build #43341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43341/consoleFull)
for PR 8971 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146307412
[Test build #43329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43329/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146307602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146307599
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146273752
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146273707
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146275566
[Test build #43329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43329/consoleFull)
for PR 8971 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41430216
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -88,7 +88,7 @@ final class Decimal extends Ordered[Decimal] with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41430109
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -117,9 +135,14 @@ private[sql] object ColumnAccessor {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41430343
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/columnar/ColumnTypeSuite.scala ---
@@ -69,176 +67,65 @@ class ColumnTypeSuite extends SparkFunSuite
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41430728
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -117,9 +135,14 @@ private[sql] object ColumnAccessor {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41430980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -102,6 +103,16 @@ private[sql] sealed abstract class
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-146293774
LGTM except for a few minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41431106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnBuilder.scala ---
@@ -109,16 +113,20 @@ private[sql] class StringColumnBuilder
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41425584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -117,9 +135,14 @@ private[sql] object ColumnAccessor {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41425580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -88,7 +88,7 @@ final class Decimal extends Ordered[Decimal] with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41425869
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -102,6 +103,16 @@ private[sql] sealed abstract class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41426190
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -399,24 +415,164 @@ private[sql] object BINARY extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41428941
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -102,6 +103,16 @@ private[sql] sealed abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41426857
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -102,6 +103,16 @@ private[sql] sealed abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41426637
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -117,9 +135,14 @@ private[sql] object ColumnAccessor {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41415962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -399,24 +409,158 @@ private[sql] object BINARY extends
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41415762
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -399,24 +409,158 @@ private[sql] object BINARY extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41352348
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -254,7 +255,7 @@ private[sql] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41352948
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -399,24 +409,158 @@ private[sql] object BINARY extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41352081
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -399,24 +409,158 @@ private[sql] object BINARY extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41353513
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -365,32 +374,33 @@ private[sql] case class FIXED_DECIMAL(precision:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41352041
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -399,24 +409,158 @@ private[sql] object BINARY extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145971061
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145971056
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145947938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145970902
[Test build #43281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43281/console)
for PR 8971 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145947768
[Test build #43276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43276/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145947937
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145933256
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145908987
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145911454
[Test build #43276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43276/consoleFull)
for PR 8971 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145934504
[Test build #43281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43281/consoleFull)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145908960
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145933219
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145611558
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145611452
[Test build #43241 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43241/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145611560
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145607323
[Test build #43241 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43241/consoleFull)
for PR 8971 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145621181
[Test build #1843 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1843/consoleFull)
for PR 8971 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145662420
[Test build #1843 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1843/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145718676
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145718674
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145718624
[Test build #43257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43257/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145673361
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145673389
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8971#discussion_r41200027
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -285,7 +284,12 @@ public UnsafeMapData getMap(int
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145675123
[Test build #43249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43249/consoleFull)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145678374
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145678371
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145678334
[Test build #43249 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43249/console)
for PR 8971 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145679568
@liancheng Could you help to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145679668
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145679692
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145680842
[Test build #43253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43253/consoleFull)
for PR 8971 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145701518
[Test build #43253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43253/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145701555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145701554
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145690634
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145690608
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145691725
[Test build #43257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43257/consoleFull)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145605320
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145605359
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145190178
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145190173
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/8971
[SPARK-10917] [SQL] improve performance of complex type in columnar cache
This PR improve the performance of complex types in columnar cache by using
UnsafeProjection instead of KryoSerializer.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145191280
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145191270
[Test build #43203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43203/console)
for PR 8971 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145191277
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8971#issuecomment-145190566
[Test build #43203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43203/consoleFull)
for PR 8971 at commit
88 matches
Mail list logo
