Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41579471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -95,98 +92,192 @@ private[sql] case
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41579349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -95,98 +92,192 @@ private[sql] case
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146316241
LGTM. Thank you for working on it! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41348104
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -95,98 +92,192 @@ private[sql] case
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41348182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -95,98 +92,192 @@ private[sql] case
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41307741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -26,7 +26,7 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41309171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -26,7 +26,7 @@ import
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145763260
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145767475
Whoops, looks like I broke something. Will bisect and figure it out
tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145767287
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145767254
[Test build #43275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43275/console)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145755326
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145755342
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145759168
[Test build #43274 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43274/console)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145759193
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145759189
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145764550
[Test build #43275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43275/consoleFull)
for PR 8973 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145756788
[Test build #43274 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43274/consoleFull)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145767289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145763248
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146015849
It looks like the old code was actually implicitly depending on some weird
`lazy val` initialization ordering properties.
---
If your project is set up for it, you
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41325223
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -26,7 +26,7 @@ import
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41308029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -26,7 +26,7 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146043554
[Test build #43303 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43303/console)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146043668
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146043665
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146025408
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146025430
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-146026024
[Test build #43303 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43303/consoleFull)
for PR 8973 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145929150
Okay, I think I might spot the problem: I bet that this was caused by my
lifting of the `lazy val cloneBufferAttributes` into the parent class; what's
probably
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145743801
[Test build #43271 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43271/consoleFull)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145743534
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145743522
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145744272
[Test build #43271 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43271/console)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145744274
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145744273
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145723873
Alright, I've gone ahead and filed a JIRA, performed some more renaming,
and added a _ton_ more Scaladoc to the new split interfaces in order to clarify
how they're
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41220510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -95,98 +92,186 @@ private[sql] case
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145724991
[Test build #43268 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43268/consoleFull)
for PR 8973 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145726838
[Test build #43268 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43268/console)
for PR 8973 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145726840
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145726841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
43 matches
Mail list logo
