[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157647941 Merged to master/1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread somideshmukh
Github user somideshmukh commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157634620 I have push new commit to SomilBranch-1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157419417 You don't need a new PR, just push a new commit here. It's better, as it preserves the history of the discussion. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread somideshmukh
Github user somideshmukh commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157408424 OK,I will remove non-DDL statements and create new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9733#discussion_r45052370 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -120,7 +120,7 @@ private[sql] object JDBCRDD extends Lo

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157010778 **[Test build #2063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2063/consoleFull)** for PR 9733 at commit [`9db069d`](https://gi

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-156982691 **[Test build #2063 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2063/consoleFull)** for PR 9733 at commit [`9db069d`](https://git

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-156981862 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-16 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-156981802 I agree with this, and am OK to merge this. There is still an issue with not closing the `Statement`s, although it's a separate issue. --- If your project is set up

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-16 Thread somideshmukh
GitHub user somideshmukh opened a pull request: https://github.com/apache/spark/pull/9733 [SPARK-10946][SQL]JDBC - Use Statement.executeUpdate instead of PreparedStatement.executeUpdate for DDLs New changes with JDBCRDD You can merge this pull request into a Git repository by runn