Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153883067
I'm going to merge this. Hopefully it will be OK -- in the past snappy
change isn't always the most robust.
---
If your project is set up for it, you can reply to this em
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153533385
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153533381
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153533167
**[Test build #44958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44958/consoleFull)**
for PR 9439 at commit
[`f9a021b`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153496753
**[Test build #44958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44958/consoleFull)**
for PR 9439 at commit
[`f9a021b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153494546
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153494516
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153494447
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153444255
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153444262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-153439396
I've opened #9439 to take this over. @a-roberts, do you mind closing this
one for now?
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153439471
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9439#issuecomment-153439539
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/9439
[SPARK-10949] Update Snappy version to 1.1.2
This is an updated version of #8995 by @a-roberts. Original description
follows:
Snappy now supports concatenation of serialized streams, this
Github user a-roberts commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-151978162
Hi, have been enjoying Spark Summit Europe, better for somebody else to
take it over; looks like the files I changed have moved around since the
testing so I imagine i
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-151623475
I'd really like to get this in; @a-roberts, could you let us know if you no
longer plan to work on this so that someone else could take over?
---
If your project is s
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-151616865
@a-roberts are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-15040
Hey @a-roberts, any chance that you could fix the merge conflicts here so
that I can re-test? I'd like to get this patch in soon so that users can
benefit from the fas
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149673620
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149673623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149673094
**[Test build #43992 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43992/consoleFull)**
for PR 8995 at commit
[`0f87052`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149631386
**[Test build #43992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43992/consoleFull)**
for PR 8995 at commit
[`0f87052`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149627411
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149627365
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149625880
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149388241
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149388242
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149387994
**[Test build #43944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43944/consoleFull)**
for PR 8995 at commit
[`0f87052`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149366110
**[Test build #43944 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43944/consoleFull)**
for PR 8995 at commit
[`0f87052`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149363591
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149363568
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149363063
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149363083
(I'll try to see if I can get Jenkins to just auto-retest this...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149039453
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149039450
[Test build #43899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43899/console)
for PR 8995 at commit
[`1949bcb`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149039452
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149039291
[Test build #43899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43899/consoleFull)
for PR 8995 at commit
[`1949bcb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149038205
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149038195
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-149037941
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958855
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958851
[Test build #43890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43890/console)
for PR 8995 at commit
[`3d650c8`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958854
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958776
[Test build #43890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43890/consoleFull)
for PR 8995 at commit
[`3d650c8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958362
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958357
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148958174
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148504304
That plan sounds fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user a-roberts commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-148102036
Cheers Josh, makes sense, I'm going to test this on our systems before
updating the PR with the changes, here's what I've added (the last parts of
each code block).
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-147872165
Hey @a-roberts,
How about this:
- Add a `private[spark]` method to the `private[spark]` `CompressionCodec`
companion object and have that method main
Github user a-roberts commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-147657380
Josh, apologies for the late response here and making sure I'm
understanding your proposal
For your first comment the naive way would to be add SnappyCompressi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-146982705
Any update here? Will you have time to address my comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-145967325
[Test build #1845 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1845/console)
for PR 8995 at commit
[`352bb3d`](https://github
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-145927459
By the way, in addition to the changes here we need to update code
elsewhere in order to benefit from the concatenation of serialized streams. For
the Tungsten shuffle
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-145926286
Snappy upgrades have historically been a cause of bugs in the past, so I'm
going to veto putting this into 1.5.2. Let's definitely consider it for Spark
1.6, though.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-145919186
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8995#issuecomment-145918613
[Test build #1845 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1845/consoleFull)
for PR 8995 at commit
[`352bb3d`](https://git
GitHub user a-roberts opened a pull request:
https://github.com/apache/spark/pull/8995
[SPARK-10949] Update Snappy version to 1.1.2
Snappy now supports concatenation of serialized streams, this patch
contains a version number change and the "does not support" test is now a
"support
60 matches
Mail list logo
