[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9037#discussion_r47317124 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -434,6 +435,22 @@ class LogisticRegressionModel private[ml]

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-163821070 LGTM except the minor style. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-163865696 Merged into master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9037 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-163843508 **[Test build #47568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47568/consoleFull)** for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-163848156 **[Test build #47568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47568/consoleFull)** for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-163848226 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-163848225 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-161235524 **[Test build #2149 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2149/consoleFull)** for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-161249982 **[Test build #2149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2149/consoleFull)** for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-12-01 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-161093434 Hey @jkbradley or @dbtsai could you merge this if it looks ok to you as well? @yu-iskw took a look and the change is similar to the change we did as part of

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-11-16 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-157283184 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-27 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-151676928 re-ping @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-09 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146957711 cc @jkbradley who asked for this change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146701665 [Test build #43433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43433/consoleFull) for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/9037 [SPARK-10991][ML] logistic regression training summary handle empty prediction col LogisticRegression training summary should still function if the predictionCol is set to an empty string or

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146702024 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146702021 [Test build #43433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43433/console) for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146702025 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146701173 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146701153 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146731721 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146731650 [Test build #43446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43446/console) for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146731720 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146726783 [Test build #43446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43446/consoleFull) for PR 9037 at commit

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146726078 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10991][ML] logistic regression training...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9037#issuecomment-146726063 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not