[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41925769 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41925843 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41925685 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41916319 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41583866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41583796 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41583685 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41583304 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146690958 Since this is the infrastructural work of encoder/decoder, let's merge this and use a follow-up pr to address the comments. So, other people can start to play with it. -

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146685224 Overall looks good! Left a few clarification questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41568645 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41568528 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */ pri

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41567674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */ pri

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41566743 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */ pri

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41566709 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */ pri

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41566470 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */ pri

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41565813 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -75,6 +76,242 @@ trait ScalaReflection { */ pri

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41565489 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146421172 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146421173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146421116 [Test build #43378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43378/console) for PR 9019 at commit [`89d35cb`](https://github.

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146405461 [Test build #43378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43378/consoleFull) for PR 9019 at commit [`89d35cb`](https://gith

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146404765 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146404752 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146397989 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146397969 [Test build #43376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43376/console) for PR 9019 at commit [`768055d`](https://github.

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146397983 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146397119 [Test build #43376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43376/consoleFull) for PR 9019 at commit [`768055d`](https://gith

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146393923 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9019#discussion_r41469930 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -91,7 +328,6 @@ trait ScalaReflection { case t i

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9019#issuecomment-146393911 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10993] [SQL] Inital code generated enco...

2015-10-07 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/9019 [SPARK-10993] [SQL] Inital code generated encoder for product types This PR is a first cut at code generating an encoder that takes a Scala `Product` type and converts it directly into the tungsten