[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146627598 the code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146627544 Should we add an example in PR description? i.e. what an expression's `toString` returns before and what it is now. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146629780 Thanks, description updated. merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146405228 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/9022 [SPARK-10998] [SQL] Show non-children in default Expression.toString Its pretty hard to debug problems with expressions when you can't see all the arguments. You can merge this pull request into

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146421608 [Test build #43379 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43379/console) for PR 9022 at commit

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146405214 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146421665 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146421664 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10998] [SQL] Show non-children in defau...

2015-10-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9022#issuecomment-146407066 [Test build #43379 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43379/consoleFull) for PR 9022 at commit