[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148782895 ah, btw, can you fix the pr description to reflect the actual change? thanks! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-16 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148775462 Much better. :-) LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148594541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148594538 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148594483 [Test build #43830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43830/console) for PR 9026 at commit [`58dcf4d`](https://github.

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148591242 [Test build #43830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43830/consoleFull) for PR 9026 at commit [`58dcf4d`](https://gith

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148589643 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-148589568 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread SaintBacchus
Github user SaintBacchus commented on a diff in the pull request: https://github.com/apache/spark/pull/9026#discussion_r42205797 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1272,11 +1272,24 @@ object Client extends Logging { val mirror

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9026#discussion_r42183714 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1272,11 +1272,24 @@ object Client extends Logging { val mirror = univ

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-13 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147664500 OK I confess I don't know this aspect well but I think you explained how this is different from just accidentally making two HiveContexts here. To my knowledge it sounds

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-13 Thread SaintBacchus
Github user SaintBacchus commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147660393 Actually there are two metastores. In hive-1.2.1 when we use `metastoe.Hive`, it will create the metastore in static code block. As spark have two class loader(main

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-13 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147644840 Makes sense. Is it a problem that we actually have two metastores? Maybe not. That's my only question, looking at this from the outside. --- If your project is set up fo

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-12 Thread SaintBacchus
Github user SaintBacchus commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147614244 @srowen In this issue there is only one `HiveContext`, but there will have two `metastoe.Hive` instance in two different class loaderes. And in the implement of `m

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147607515 This looks reasonable but as in SPARK-9776 should there ever be two HiveContexts open, or is this triggered without that? is it a problem that there are two database inst

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-09 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147030150 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-09 Thread SaintBacchus
Github user SaintBacchus commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-147023274 /cc @marmbrus @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-146460548 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-146460547 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-146460424 [Test build #43390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43390/console) for PR 9026 at commit [`0fab8c7`](https://github.

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-146450878 [Test build #43390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43390/consoleFull) for PR 9026 at commit [`0fab8c7`](https://gith

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-146449971 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9026#issuecomment-146449937 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11000][YARN]Bug fix: Derby have booted ...

2015-10-08 Thread SaintBacchus
GitHub user SaintBacchus opened a pull request: https://github.com/apache/spark/pull/9026 [SPARK-11000][YARN]Bug fix: Derby have booted the database twice in yarn security mode. [obtainTokenForHiveMetastore](https://github.com/apache/spark/blob/master/yarn/src/main/scala/org/apache