Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146729145
YAY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146715345
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146715340
[Test build #43438 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43438/console)
for PR 9038 at commit
[`7a34e03`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146715344
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41582004
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -511,8 +658,10 @@ class TungstenAggrega
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581951
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -288,17 +419,33 @@ class TungstenAggreg
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146714227
[Test build #43438 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43438/consoleFull)
for PR 9038 at commit
[`7a34e03`](https://gith
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581748
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -187,72 +266,124 @@ class TungstenAggre
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581661
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -170,10 +232,27 @@ class TungstenAggreg
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581609
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -170,10 +232,27 @@ class TungstenAggreg
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581411
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -134,19 +137,73 @@ class TungstenAggreg
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146713043
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146713029
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -367,7 +368,7 @@ abstract class AggregationIter
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -321,7 +321,7 @@ abstract class AggregationIter
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9038#discussion_r41581219
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -546,6 +546,9 @@ case class HyperLogLogPlu
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9038#issuecomment-146712508
/cc @yhuai for review. There are a few specific questions that I'd like to
clarify and I will comment on them inline.
---
If your project is set up for it, you can re
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/9038
[SPARK-11017] Support ImperativeAggregates in TungstenAggregate
This patch extends TungstenAggregate to support ImperativeAggregate
functions. The existing TungstenAggregate operator only supporte
18 matches
Mail list logo
