Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42876278
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42831433
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42831391
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -127,37 +170,28 @@ private[netty] class NettyRpcEnv(
val ack =
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150458214
LGTM.
@vanzin if you have time to take a closer look, that'd be great.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42831447
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149960061
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149960020
> Test build #44062 has finished for PR 9197 at commit a3246e5.
>
> This patch fails from timeout after a configured wait of `250m`.
> This patch merges
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149961297
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149961349
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149950246
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149950155
**[Test build #44062 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44062/consoleFull)**
for PR 9197 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149950241
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149962448
**[Test build #44072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44072/consoleFull)**
for PR 9197 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149995104
**[Test build #44072 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44072/consoleFull)**
for PR 9197 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149995302
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149995300
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150063982
I was hoping we could somehow avoid needing an outbox, but I guess that's
the easiest way to go. The code LGTM, although I'll probably take another look.
---
If your
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42702274
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -116,6 +135,30 @@ private[netty] class NettyRpcEnv(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42702265
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -116,6 +135,30 @@ private[netty] class NettyRpcEnv(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150069425
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150069414
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150070171
**[Test build #44114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44114/consoleFull)**
for PR 9197 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42699677
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -116,6 +135,30 @@ private[netty] class NettyRpcEnv(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42699651
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -116,6 +135,30 @@ private[netty] class NettyRpcEnv(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42699953
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -116,6 +135,30 @@ private[netty] class NettyRpcEnv(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9197#discussion_r42699555
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -70,12 +71,30 @@ private[netty] class NettyRpcEnv(
// Because
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149892333
**[Test build #44060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44060/consoleFull)**
for PR 9197 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149892607
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149892610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150095096
**[Test build #44114 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44114/consoleFull)**
for PR 9197 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150095186
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-150095187
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149860749
**[Test build #44060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44060/consoleFull)**
for PR 9197 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149869454
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/9197
[SPARK-11098][Core]Add Outbox to cache the sending messages to resolve the
message disorder issue
The current NettyRpc has a message order issue because it uses a thread
pool to send messages.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149859506
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149859522
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149870944
**[Test build #44062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44062/consoleFull)**
for PR 9197 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149859379
cc @rxin, @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9197#issuecomment-149869440
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
41 matches
Mail list logo
