[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149979698 This looks great. I'm going to merge so that I can resolve any conflicts with #9190. We can continue to address comments / TODOs in a follow up PR. --- If your proje

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42659562 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -446,3 +455,32 @@ case class MapObjects( """

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42659507 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42659452 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ClassEncoder.scala --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149906067 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149906069 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149905864 **[Test build #44061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44061/consoleFull)** for PR 9184 at commit [`4551a92`](https://git

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149867251 **[Test build #44061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44061/consoleFull)** for PR 9184 at commit [`4551a92`](https://gith

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149864264 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149864305 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149840158 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149840164 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149840143 **[Test build #44058 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44058/consoleFull)** for PR 9184 at commit [`b08da16`](https://git

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149839340 **[Test build #44058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44058/consoleFull)** for PR 9184 at commit [`b08da16`](https://gith

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149837327 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149837259 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149636079 This is looking great! Thanks for coming up with a draft so quickly. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42523911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoder.scala --- @@ -44,6 +45,18 @@ object ProductEncoder { va

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42523870 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoder.scala --- @@ -44,6 +45,18 @@ object ProductEncoder { va

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42523789 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoderSuite.scala --- @@ -215,6 +217,42 @@ class ProductEncoderSuite ex

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42523439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoder.scala --- @@ -44,6 +45,18 @@ object ProductEncoder { va

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42523411 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -141,8 +142,73 @@ trait ScalaReflection { ObjectTy

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42523011 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoderSuite.scala --- @@ -215,6 +217,42 @@ class ProductEncoderSuite ex

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9184#discussion_r42522939 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ProductEncoderSuite.scala --- @@ -215,6 +217,42 @@ class ProductEncoderSuite ex

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149627367 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149627363 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149627338 **[Test build #43991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43991/consoleFull)** for PR 9184 at commit [`4751418`](https://git

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149625266 **[Test build #43991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43991/consoleFull)** for PR 9184 at commit [`4751418`](https://gith

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149624427 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9184#issuecomment-149624405 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11216][SQL] add encoder/decoder for ext...

2015-10-20 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9184 [SPARK-11216][SQL] add encoder/decoder for external row You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark encoder Alternatively