Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150119806
is it possible for lin-r to skip # comment with code outside a function
body?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user saurfang commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150329264
Thanks @shivaram! Opened https://issues.apache.org/jira/browse/SPARK-11263
for further discussion.
---
If your project is set up for it, you can reply to this email
Github user saurfang commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150202122
I still advocate making developer API documentation public. However I think
one workaround is to make them roxygen doc again with `#'` but add `#' @rdname
.ignore` for
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150281360
@saurfang Can you open a new JIRA for these style failures ? We can discuss
the points there.
LGTM. Merging this in master and branch-1.5
---
If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150281695
cc @olarayej
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user saurfang opened a pull request:
https://github.com/apache/spark/pull/9205
[SPARK-11244][SPARKR] sparkR.stop() should remove SQLContext
SparkR should remove `.sparkRSQLsc` and `.sparkRHivesc` when
`sparkR.stop()` is called. Otherwise even when SparkContext is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150013859
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150013828
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150015431
Thanks @saurfang -- Test is fine in the current location. Just curious what
are the lint-r errors you saw ?
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150015657
**[Test build #44086 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44086/consoleFull)**
for PR 9205 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150019771
**[Test build #44086 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44086/consoleFull)**
for PR 9205 at commit
Github user saurfang commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150021998
I see. Thanks for the information. I thought the convention in R package is
to expose as much documentation as possible but don't export functions that is
unstable or
Github user saurfang commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150017327
Most of them are "style: Commented code should be removed."
For example:
```
R/RDD.R:260:3: style: Commented code should be removed.
#
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150018896
Ah I see. Hmm we use `#` instead of `#'` for a bunch of cases where we dont
want roxygen to parse it as the functions are not part of the public API. Not
sure if there
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150019957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9205#issuecomment-150019956
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
17 matches
Mail list logo
