Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151259944
@scwf It will not be merged to branch-1.5 because our UI handles those
metric updates correctly. This problem was exposed after we call the
`QueryExecutionListener` logic
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151041137
should this merged to branch-1.5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151031307
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151029350
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151029349
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151029277
**[Test build #44332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44332/consoleFull)**
for PR 9215 at commit
[`6923c4f`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151013772
**[Test build #44332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44332/consoleFull)**
for PR 9215 at commit
[`6923c4f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151013026
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-151013028
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42957236
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -80,4 +80,71 @@ class DataFrameCallbackSuite extends QueryT
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42952784
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -80,4 +80,71 @@ class DataFrameCallbackSuite extends QueryTest
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150941933
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150941936
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150941908
**[Test build #44319 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44319/consoleFull)**
for PR 9215 at commit
[`b088c70`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150931394
**[Test build #44319 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44319/consoleFull)**
for PR 9215 at commit
[`b088c70`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150930124
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150930195
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42930194
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -62,7 +67,19 @@ private[sql] trait SQLMetricValue[T] extends
S
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42929484
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -62,7 +67,19 @@ private[sql] trait SQLMetricValue[T] extend
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-15067
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150673263
**[Test build #44237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44237/consoleFull)**
for PR 9215 at commit
[`4ff8912`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150673330
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42892965
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -62,7 +67,19 @@ private[sql] trait SQLMetricValue[T] extends
S
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150643054
**[Test build #44237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44237/consoleFull)**
for PR 9215 at commit
[`4ff8912`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150640729
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150640759
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150414422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150414133
**[Test build #44186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44186/consoleFull)**
for PR 9215 at commit
[`778992e`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150414417
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150392925
**[Test build #44186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44186/consoleFull)**
for PR 9215 at commit
[`778992e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150392433
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150392446
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150291397
Can you also double check if our ui looks good after this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42775206
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
---
@@ -80,4 +80,24 @@ class DataFrameCallbackSuite extends QueryTest
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150126796
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150126795
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150126583
**[Test build #44129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44129/consoleFull)**
for PR 9215 at commit
[`6397cf5`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150119572
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150119571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150119505
**[Test build #44126 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44126/consoleFull)**
for PR 9215 at commit
[`4589e66`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150106420
**[Test build #44129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44129/consoleFull)**
for PR 9215 at commit
[`6397cf5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150106101
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150106110
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9215#discussion_r42710749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -28,7 +28,12 @@ import org.apache.spark.{Accumulable, Accumulabl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150100797
**[Test build #44126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44126/consoleFull)**
for PR 9215 at commit
[`4589e66`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150100155
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9215#issuecomment-150100164
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/9215
[SPARK-11253][SQL] reset all accumulators in physical operators before
execute an action
With this change, our query execution listener can get the metrics
correctly.
You can merge this pull req
49 matches
Mail list logo
