[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-27 Thread dahlem
Github user dahlem closed the pull request at: https://github.com/apache/spark/pull/9252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9252#issuecomment-151371779 @dahlem If you plan to make a new pull request, could you close this PR manually? We don't have direct access to close Spark PRs. Thanks! --- If your project is set up f

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-26 Thread dahlem
Github user dahlem commented on the pull request: https://github.com/apache/spark/pull/9252#issuecomment-151344091 That makes sense. I fixed it on my branch and will create a pull request against a new ticket. On Fri, Oct 23, 2015 at 10:43 PM, Felix Cheung wrote:

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-23 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9252#issuecomment-150700335 Shouldn't this be fixed/casted in the `RegressionEvaluator` instead? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-23 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9252#issuecomment-150607991 @dahlem Any issue with float precision? The ratings do not have high precision anyway. Changing it to double precision increases the shuffle size by a lot. If you want to

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9252#issuecomment-150586598 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-23 Thread dahlem
GitHub user dahlem opened a pull request: https://github.com/apache/spark/pull/9252 [SPARK-11284] [ML] ALS produces float predictions instead of double @mengxr This pull request just changes the float predictions into doubles with corresponding changes to use the double precisi