Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156558597
LGTM. Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156331018
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156331014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156330726
**[Test build #45832 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45832/consoleFull)**
for PR 9320 at commit
[`128eb70`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156328419
**[Test build #45832 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45832/consoleFull)**
for PR 9320 at commit
[`128eb70`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156328084
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156328099
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156327835
@mengxr fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9320#discussion_r44751333
--- Diff: docs/_plugins/include_example.rb ---
@@ -38,7 +38,16 @@ def render(context)
code = File.open(@file).read.encode("UTF-8")
code
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9320#discussion_r44751245
--- Diff: docs/_plugins/include_example.rb ---
@@ -38,7 +38,16 @@ def render(context)
code = File.open(@file).read.encode("UTF-8")
code =
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156327208
The underline is confusing because people would treat it as a hyperlink,
which is actually not. We can simply say: `Find full example code at
"examples/src/main/#{clean_m
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156017610
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156017611
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156017460
**[Test build #45714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45714/consoleFull)**
for PR 9320 at commit
[`f7e6618`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156013909
**[Test build #45714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45714/consoleFull)**
for PR 9320 at commit
[`f7e6618`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156012704
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156012721
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-156012676
I delete the hyperlink and add an underscore of the file address. It looks
more clear.
---
If your project is set up for it, you can reply to this email and have your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-155869334
@yinxusen Let's take a safe approach. Remove the link but leave the text:
~~~
Find full example code at examples/src/main/#{clean_markup} in the Spark
repo.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153561627
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153561626
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153561555
**[Test build #44994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44994/consoleFull)**
for PR 9320 at commit
[`9f8b7b5`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153559928
**[Test build #44994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44994/consoleFull)**
for PR 9320 at commit
[`9f8b7b5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153559570
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153559587
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153559523
@mengxr I am not sure how to use the `PRODUCTION` flag. But how about
using the comparison between `SPARK_VERSION_SHORT` and `SPARK_VERSION` in the
`_config.yml` file?
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153537027
When we build the doc, there is a flag `PRODUCTION`. I think when this flag
is on, we should use Spark version in the GitHub link, otherwise we should use
`master` instea
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9320#discussion_r43830050
--- Diff: docs/_plugins/include_example.rb ---
@@ -38,7 +38,15 @@ def render(context)
code = File.open(@file).read.encode("UTF-8")
code =
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153233503
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153233502
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153233461
**[Test build #44873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44873/consoleFull)**
for PR 9320 at commit
[`0f5528d`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153232325
**[Test build #44873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44873/consoleFull)**
for PR 9320 at commit
[`0f5528d`](https://gith
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9320#discussion_r43713631
--- Diff: docs/_plugins/include_example.rb ---
@@ -38,7 +38,15 @@ def render(context)
code = File.open(@file).read.encode("UTF-8")
code
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153231612
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153231626
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-153170024
LGTM except some minor issues mentioned inline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9320#discussion_r43688663
--- Diff: docs/_plugins/include_example.rb ---
@@ -38,7 +38,15 @@ def render(context)
code = File.open(@file).read.encode("UTF-8")
code =
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9320#discussion_r43688658
--- Diff: docs/_plugins/include_example.rb ---
@@ -38,7 +38,15 @@ def render(context)
code = File.open(@file).read.encode("UTF-8")
code =
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-151735689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-151735616
**[Test build #44500 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44500/consoleFull)**
for PR 9320 at commit
[`a556c50`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-151735688
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-151734093
**[Test build #44500 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44500/consoleFull)**
for PR 9320 at commit
[`a556c50`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-15177
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9320#issuecomment-151733327
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/9320
[SPARK-11336] Add links to example codes
https://issues.apache.org/jira/browse/SPARK-11336
@mengxr I add a hyperlink of Spark on Github and a hint of their existences
in Spark code repo in
46 matches
Mail list logo
