Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153922944
Merged into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wzhfy commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153922195
@davies The description is updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153589152
**[Test build #1975 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1975/consoleFull)**
for PR 9349 at commit
[`d15e14a`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153567183
**[Test build #1975 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1975/consoleFull)**
for PR 9349 at commit
[`d15e14a`](https://git
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153567087
The changes LGTM, could you update the description to reflect the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wzhfy commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153553626
@davies Thanks for the advice. The commit has been updated, please check if
that's what we want.
Btw, I think the cause of this problem is the inconsistency betwee
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153448480
@wzhfy The first part change is good (remove dialectClassName). But other
one may introduce regression, when you have `spark.sql.dialect sql` in
conf/spark-default.conf,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153291000
**[Test build #1972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1972/consoleFull)**
for PR 9349 at commit
[`6dec533`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153262712
**[Test build #1972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1972/consoleFull)**
for PR 9349 at commit
[`6dec533`](https://git
Github user wzhfy commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-153262162
@davies @liancheng I've updated the description of this problem, hoping to
explain it better now.
Can you review this pr and authorize testing? thx.
---
If your proje
11 matches
Mail list logo
