Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153961472
Merging into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153953991
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153953990
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153953872
**[Test build #45078 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45078/consoleFull)**
for PR 9383 at commit
[`b1f8a99`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153926678
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153926674
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153926511
**[Test build #45078 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45078/consoleFull)**
for PR 9383 at commit
[`b1f8a99`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153925290
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153925266
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153924528
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153924544
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153905171
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153905169
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153902810
LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153902260
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153902240
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43955966
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMap.java
---
@@ -243,9 +243,8 @@ public void printPerfMetrics() {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153902056
**[Test build #45062 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45062/consoleFull)**
for PR 9383 at commit
[`10d7169`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153902062
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153902064
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153901565
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43955709
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMapSuite.scala
---
@@ -183,31 +180,30 @@ class UnsafeFixedWidthAgg
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153901175
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153901178
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153900874
**[Test build #45062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45062/consoleFull)**
for PR 9383 at commit
[`10d7169`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153899733
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153899674
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43954658
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -386,24 +388,37 @@ public void insertKVRecord(Object
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43954523
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -83,11 +83,8 @@ public UnsafeKVExternalSorter(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43954148
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -386,24 +388,37 @@ public void insertKVRecord(Objec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153897490
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153897527
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43951682
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -83,11 +83,8 @@ public UnsafeKVExternalSorter(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43951086
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -122,11 +119,7 @@ public UnsafeKVExternalSorter(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43951008
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -83,11 +83,8 @@ public UnsafeKVExternalSorter(
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43951003
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMap.java
---
@@ -243,9 +243,8 @@ public void printPerfMetrics() {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43950924
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -647,7 +648,7 @@ public boolean putNewKey(Object keyBase, long
keyOffset,
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43950528
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMap.java
---
@@ -243,9 +243,8 @@ public void printPerfMetrics() {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43949296
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -386,24 +388,37 @@ public void insertKVRecord(Object
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43949255
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -122,11 +119,7 @@ public UnsafeKVExternalSorter(
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43949044
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeKVExternalSorter.java
---
@@ -83,11 +83,8 @@ public UnsafeKVExternalSorter(
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43947627
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -647,7 +648,7 @@ public boolean putNewKey(Object keyBase, long
keyOffset,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153824690
**[Test build #1978 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1978/consoleFull)**
for PR 9383 at commit
[`1c0c6c3`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153776895
**[Test build #1978 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1978/consoleFull)**
for PR 9383 at commit
[`1c0c6c3`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153643853
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153643851
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153643706
**[Test build #45001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45001/consoleFull)**
for PR 9383 at commit
[`1c0c6c3`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153618536
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153618538
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153618311
**[Test build #44997 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44997/consoleFull)**
for PR 9383 at commit
[`fc5e052`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153596433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153596430
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153595974
**[Test build #45001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45001/consoleFull)**
for PR 9383 at commit
[`1c0c6c3`](https://gith
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153595672
@JoshRosen @yhuai pushed a refactor on this (reduce possibility of full GC
by re-use the array in map), please take another look.
---
If your project is set up for it, y
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43846718
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -589,6 +588,13 @@ abstract class AggregationQuerySuit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43846549
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -386,24 +388,37 @@ public void insertKVRecord(Objec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153591839
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153591862
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153590796
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153590823
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153573130
**[Test build #44997 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44997/consoleFull)**
for PR 9383 at commit
[`fc5e052`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153572263
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153572253
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43841671
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -502,44 +511,37 @@ class TungstenAggregati
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153552009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153552008
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153551889
**[Test build #44972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44972/consoleFull)**
for PR 9383 at commit
[`6f3bb15`](https://git
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43828335
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -589,6 +588,13 @@ abstract class AggregationQuerySuite
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43828243
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMapSuite.scala
---
@@ -183,31 +180,30 @@ class UnsafeFixedWidthAggr
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43827776
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -502,44 +511,37 @@ class TungstenAggregatio
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43827738
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -502,44 +511,37 @@ class TungstenAggregatio
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43827568
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -762,15 +679,7 @@ class TungstenAggregatio
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9383#discussion_r43826631
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -762,15 +679,7 @@ class TungstenAggregation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153528665
**[Test build #44972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44972/consoleFull)**
for PR 9383 at commit
[`6f3bb15`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153528306
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153528327
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153527858
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153527297
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153527299
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9383#issuecomment-153527227
**[Test build #44959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44959/consoleFull)**
for PR 9383 at commit
[`6f3bb15`](https://git
81 matches
Mail list logo
