Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9417
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-154001929
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153696906
LGTM. Let me leave it open a bit for comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9417#discussion_r43870851
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -177,39 +170,24 @@ class PortableDataStream(
}
/**
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9417#discussion_r43869486
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -177,39 +170,24 @@ class PortableDataStream(
}
/**
Github user kmader commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153550148
@srowen @hvanhovell this is a nice improvement and more elegant than the
original approach.
As a side node, In our code base (which uses PortableDataStream quite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153133888
**[Test build #1968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1968/consoleFull)**
for PR 9417 at commit
[`91b8c6c`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153095896
**[Test build #1968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1968/consoleFull)**
for PR 9417 at commit
[`91b8c6c`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153095133
**[Test build #1967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1967/consoleFull)**
for PR 9417 at commit
[`91b8c6c`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153060623
**[Test build #1967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1967/consoleFull)**
for PR 9417 at commit
[`91b8c6c`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153059875
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9417#issuecomment-153059923
@kmader what do you think of this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/9417
[SPARK-11449][Core] PortableDataStream should be a factory
```PortableDataStream``` maintains some internal state. This makes it
tricky to reuse a stream (one needs to call ```close``` on both th
13 matches
Mail list logo
