Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169417305
LGTM. Merging with master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169217559
**[Test build #48829 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48829/consoleFull)**
for PR 9525 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169202932
**[Test build #48811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48811/consoleFull)**
for PR 9525 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169226815
**[Test build #48831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48831/consoleFull)**
for PR 9525 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169217920
**[Test build #48830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48830/consoleFull)**
for PR 9525 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169220366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169220825
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169220824
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169220800
**[Test build #48830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48830/consoleFull)**
for PR 9525 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169205356
**[Test build #48811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48811/consoleFull)**
for PR 9525 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169205403
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169205402
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169231913
**[Test build #48831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48831/consoleFull)**
for PR 9525 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169232218
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169232216
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169202223
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169202224
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169220344
**[Test build #48829 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48829/consoleFull)**
for PR 9525 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169220367
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169157238
@rekhajoshm +1 for the suggestion from @mengxr Could you please update
this accordingly? Thanks! (Or please comment if you don't have time.)
@urvishparikh
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169196705
Thanks @jkbradley might have missed it or thought it was under
discussion.updated.thanks
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154503795
Build started sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154508219
I think it would be natural to fix the Scala error message and fix the
condition in Python. The algorithm checks not the indexes have duplicated
values, but the indexes
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/spark/pull/9525
[SPARK-11531] [ML] : SparseVector error Msg
PySpark SparseVector should have "Found duplicate indices" error message
You can merge this pull request into a Git repository by running:
$ git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154503752
Build triggered. sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154504166
**[Test build #45236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45236/consoleFull)**
for PR 9525 at commit
Github user urvishparikh commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154510035
@yu-iskw The indices are sorted within the code base at:
https://github.com/apache/spark/blob/master/python/pyspark/mllib/linalg/__init__.py#L510
So
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154522069
@urvishparikh People need to know the indices are ordered to understand the
implementation here. It would be better if you put both the i-th index and the
(i+1)-th index
Github user urvishparikh commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154516022
Yes but for consistency sake (and for ensuring sortedness which is crucial
for SparseVector to function) I think the >= condition is fine.
---
If your project is
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154512438
@urvishparikh oh, got it. Thank you for letting me know. It's my fault.
If the indexes are already sorted, the condition should be `==`, right?
---
If your project
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154518546
All right. We should focus on change the error message in this issue. Thank
you for making it clear.
LGTM
---
If your project is set up for it, you can reply
Github user urvishparikh commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154524005
Yes I agree @mengxr that much is definitely true. If we make that change
here then we also have to make that corresponding change in the scala version.
---
If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154531341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45236/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-154531323
Build finished. No test results found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
35 matches
Mail list logo
