Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163442658
@BenFradet I'll change it in the follow-up PR
https://github.com/apache/spark/pull/10193
---
If your project is set up for it, you can reply to this email and have yo
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163389541
LGTM, except two minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47150356
--- Diff: examples/src/main/python/ml/polynomial_expansion_example.py ---
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) un
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47147519
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBinarizerExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Softwa
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47143681
--- Diff: docs/ml-features.md ---
@@ -794,39 +411,7 @@ dctDf.select("featuresDCT").show(3)
Refer to the [DCT Java docs](api/java/org/apache/spark/ml/featu
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163373814
Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163213528
@yinxusen I'll have a look later today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163211572
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163211570
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163211490
**[Test build #47427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47427/consoleFull)**
for PR 10219 at commit
[`771d015`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163203400
**[Test build #47427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47427/consoleFull)**
for PR 10219 at commit
[`771d015`](https://gi
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163203243
@BenFradet Does the code look good for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163173174
@BenFradet It's reasonable. I'll modify them now. Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163165116
I notice some formatting quirks, especially for scala examples, otherwise
it looks good.
However, shouldn't we take advantage of this pr to standardize the ou
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47068916
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/ElementWiseProductExample.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47068461
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/OneHotEncoderExample.scala
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Soft
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47068389
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/PCAExample.scala ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Founda
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47068305
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/PolynomialExpansionExample.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apach
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10219#discussion_r47068203
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/StringIndexerExample.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Soft
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163138018
Ping @mengxr, this is for SPARK-11551. Please sign it off if looks good to
you.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163137574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163137570
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163137492
**[Test build #47413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47413/consoleFull)**
for PR 10219 at commit
[`8748a88`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163135226
**[Test build #47413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47413/consoleFull)**
for PR 10219 at commit
[`8748a88`](https://gi
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/10219#issuecomment-163133018
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/10219
[SPARK-11551][DOC] Replace example code in ml-features.md using
include_example
PR on behalf of @somideshmukh, thanks!
You can merge this pull request into a Git repository by running:
$ git
27 matches
Mail list logo
