[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9939 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163706850 LGTM. I'll merge this with master and branch-1.6 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163472596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163472594 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163472496 **[Test build #47468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47468/consoleFull)** for PR 9939 at commit [`57c78a5`](https://git

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163466954 **[Test build #47468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47468/consoleFull)** for PR 9939 at commit [`57c78a5`](https://gith

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47179653 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Since(

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47142226 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Since(

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47142000 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -529,7 +529,7 @@ class LinearRegressionSummary private[regression]

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-09 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47122724 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Sin

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163096126 **[Test build #2188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2188/consoleFull)** for PR 9939 at commit [`319e61d`](https://gi

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163091443 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163091440 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163090721 **[Test build #2188 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2188/consoleFull)** for PR 9939 at commit [`319e61d`](https://git

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47046310 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD @Sin

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47045951 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -529,7 +529,7 @@ class LinearRegressionSummary private[regressi

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47045847 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -52,6 +52,10 @@ private[feature] trait StringIndexerBase extends Params

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163015502 Done with pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47012275 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -529,7 +529,7 @@ class LinearRegressionSummary private[regressio

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47011854 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala --- @@ -52,6 +52,10 @@ private[feature] trait StringIndexerBase extends Param

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9939#discussion_r47011901 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/package-info.java --- @@ -23,7 +23,7 @@ * features into more suitable forms for model fitti

[GitHub] spark pull request: [SPARK-11602] [MLlib] Refine visibility for 1....

2015-12-08 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9939#issuecomment-163014149 My apologies! I lost track of this PR, but will check again now. Could you please resolve the merge conflicts? --- If your project is set up for it, you can reply t