[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45300560 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1997,4 +1997,18 @@ class SQLQuerySuite extends QueryTest with SharedSQL

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45300217 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1997,4 +1997,18 @@ class SQLQuerySuite extends QueryTest with SharedSQLC

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157943394 **[Test build #46294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46294/consoleFull)** for PR 9762 at commit [`ed1aab0`](https://gith

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157939644 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157939450 **[Test build #46283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46283/consoleFull)** for PR 9762 at commit [`b71f32b`](https://git

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157939642 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45295954 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,20 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45293109 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,20 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45292526 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,20 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45292131 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,20 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157919365 **[Test build #46283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46283/consoleFull)** for PR 9762 at commit [`b71f32b`](https://gith

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45288031 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,18 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45288006 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -425,7 +425,8 @@ class Analyzer( */

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45285626 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -425,7 +425,8 @@ class Analyzer( */

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45285686 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,18 @@ class SQLQuerySuite extends QueryTest w

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45285365 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -425,7 +425,8 @@ class Analyzer( */

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45285001 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,18 @@ class SQLQuerySuite extends QueryTest w

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45284891 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,18 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45279997 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -425,7 +425,8 @@ class Analyzer( */

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9762#discussion_r45279985 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -1479,4 +1481,18 @@ class SQLQuerySuite extends QueryTest w

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157857086 @marmbrus @cloud-fan Based on your comments, I did the change. Please review the new change. I also tried the fix after excluding the change in `attributeRew

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157855341 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157855340 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157855114 **[Test build #46228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46228/consoleFull)** for PR 9762 at commit [`d1d2f30`](https://git

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157816988 **[Test build #46228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46228/consoleFull)** for PR 9762 at commit [`d1d2f30`](https://gith

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157786406 @cloud-fan @marmbrus Will follow your suggestions to update the fix. Thanks! --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157783851 @cloud-fan s suggestion sounds correct to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-18 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157696398 it looks to me that it's a bug of [`LogicalRDD`](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala#L7

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157324767 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157324764 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157324619 **[Test build #46071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46071/consoleFull)** for PR 9762 at commit [`7d48e1e`](https://git

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9762#issuecomment-157304910 **[Test build #46071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46071/consoleFull)** for PR 9762 at commit [`7d48e1e`](https://gith

[GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...

2015-11-17 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/9762 [SPARK-11633] [SQL] HiveContext's Case Insensitivity in Self-Join Handling When handling self joins, the implementation did not consider the case insensitivity of HiveContext. It could cause an