Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9769
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160452624
LGTM. Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160418454
**[Test build #46847 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46847/consoleFull)**
for PR 9769 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160418494
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160418496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160417514
**[Test build #46847 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46847/consoleFull)**
for PR 9769 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160373978
LGTM but for a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9769#discussion_r46087941
--- Diff: R/pkg/R/DataFrame.R ---
@@ -700,25 +700,28 @@ setMethod("collect",
# data of complex type can be held. But getting a cell
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9769#discussion_r46088623
--- Diff: R/pkg/R/DataFrame.R ---
@@ -700,25 +700,28 @@ setMethod("collect",
# data of complex type can be held. But getting a cell
from
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9769#discussion_r46011950
--- Diff: R/pkg/R/DataFrame.R ---
@@ -700,25 +700,28 @@ setMethod("collect",
# data of complex type can be held. But getting a cell
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9769#discussion_r46012852
--- Diff: R/pkg/R/DataFrame.R ---
@@ -700,25 +700,28 @@ setMethod("collect",
# data of complex type can be held. But getting a cell
from
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160023496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160023492
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160023298
**[Test build #46792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46792/consoleFull)**
for PR 9769 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160013831
looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-160018492
**[Test build #46792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46792/consoleFull)**
for PR 9769 at commit
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-159458260
@shivaram, @felixcheung, could you take more look? another PR depends on
this one.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-158917368
**[Test build #46532 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46532/consoleFull)**
for PR 9769 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-158922986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-158922778
**[Test build #46532 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46532/consoleFull)**
for PR 9769 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-158922984
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-158916810
@felixcheung, you concern is reasonable. I refactor the code by using
schema to determine if a collected column can be coerced into an atomic vector.
---
If your
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9769#discussion_r45419720
--- Diff: R/pkg/R/DataFrame.R ---
@@ -717,25 +717,30 @@ setMethod("collect",
# data of complex type can be held. But getting a cell
GitHub user sun-rui opened a pull request:
https://github.com/apache/spark/pull/9769
[SPARK-11781][SPARKR] SparkR has problem in inferring type of raw type.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sun-rui/spark
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157385631
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157385628
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157447807
Could you describe the problem a bit more ? Was it that raw vectors were
being treated as lists ? Just curious how raw vectors differ from int vectors
etc.
---
If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157585922
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157585897
**[Test build #46148 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46148/consoleFull)**
for PR 9769 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157585916
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157584455
**[Test build #46148 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46148/consoleFull)**
for PR 9769 at commit
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157589422
@shivaram, The R raw type is intended to hold raw bytes. while int vector
is to hold 32-bit integer values. The R raw type maps to Spark SQL binary type,
which is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157597709
**[Test build #46159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46159/consoleFull)**
for PR 9769 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157597786
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157597785
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157593732
**[Test build #46159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46159/consoleFull)**
for PR 9769 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9769#issuecomment-157614027
Ok thanks for the clarification. It might take me a couple of days to get
to this as the change looks a bit involved.
cc @felixcheung
---
If your project is
37 matches
Mail list logo
