Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-160569953
@toddwan let me know your JIRA handle and I'll credit you. Merged to
master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tawan0109 commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-160612515
@srowen https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tawan
thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-160267625
LGTM, will merge soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-160132881
**[Test build #2123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2123/consoleFull)**
for PR 9886 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-160154584
**[Test build #2123 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2123/consoleFull)**
for PR 9886 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159783968
**[Test build #46732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46732/consoleFull)**
for PR 9886 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159781566
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159781513
**[Test build #46711 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46711/consoleFull)**
for PR 9886 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159781564
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159797370
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159797334
**[Test build #46732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46732/consoleFull)**
for PR 9886 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159797372
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159783524
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159710981
**[Test build #46705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46705/consoleFull)**
for PR 9886 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159708842
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159735494
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159735493
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159735441
**[Test build #46705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46705/consoleFull)**
for PR 9886 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159738519
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159740422
**[Test build #46711 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46711/consoleFull)**
for PR 9886 at commit
Github user toddwan commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159836411
@andrewor14 I am not sure about the cause of the unit test failure, but the
failed test reported in the latest test build can pass on my machine.
---
If your project
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/9886#discussion_r45801063
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2727,6 +2726,11 @@ object SparkContext extends Logging {
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159418013
other than that, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159355373
Yes, that's pretty nice and clean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159367070
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159367395
LGTM, I'll merge this once tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159370957
**[Test build #46618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46618/consoleFull)**
for PR 9886 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159371647
**[Test build #46618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46618/consoleFull)**
for PR 9886 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159371673
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159371667
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user toddwan commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159497221
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user toddwan commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159313797
A new commit has been appended to the PR. Now a warning message is printed
first if the given mesos Master URL starts with `zk://`, then a correct mesos
Master URL is
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-159051811
+1 on having a fall back with a warning message as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-158883916
@toddwan what do you think about writing a separate code path to handle the
incorrect `zk://...` syntax? It could use the same "case", if it's a regex that
captures the
GitHub user toddwan opened a pull request:
https://github.com/apache/spark/pull/9886
[SPARK-11859][Mesos] SparkContext accepts invalid Master URLs in the form
zk://host:port for a multi-master Mesos cluster using ZooKeeper
* According to below doc and validation logic in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-158661212
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-158667956
@andrewor14 I wonder if we shouldn't first warn about this, and defer the
actual failure until 2.0. There might be people relying on this loophole. If I
understand
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9886#issuecomment-158680586
LGTM, though I tend to agree there's a little risk here in making something
that shouldn't work actually not work.
---
If your project is set up for it, you can reply
39 matches
Mail list logo
