[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-160012374 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159995282 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159995281 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159995211 **[Test build #46775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46775/consoleFull)** for PR 9995 at commit [`95b2e0d`](https://git

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159978503 **[Test build #46775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46775/consoleFull)** for PR 9995 at commit [`95b2e0d`](https://gith

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9995#discussion_r46002446 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -675,34 +675,34 @@ object PushPredicateThroughGenerate exte

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159865457 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159865386 **[Test build #46761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46761/consoleFull)** for PR 9995 at commit [`fe3a9a4`](https://git

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159865452 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9995#discussion_r45957358 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -660,14 +660,14 @@ object PushPredicateThroughGenerate exte

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9995#discussion_r45957185 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -675,34 +675,34 @@ object PushPredicateThroughGenerate exte

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9995#discussion_r45956686 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -675,34 +675,34 @@ object PushPredicateThroughGenerate

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159853541 **[Test build #46761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46761/consoleFull)** for PR 9995 at commit [`fe3a9a4`](https://gith

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9995#issuecomment-159853109 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-11973][SQL] Improve optimizer code read...

2015-11-26 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/9995 [SPARK-11973][SQL] Improve optimizer code readability. This is a followup for https://github.com/apache/spark/pull/9959. I added more documentation and rewrote some monadic code into simpler if